Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of muting nodes functionality #4517

Merged
merged 12 commits into from
Jul 1, 2022
Merged

Add support of muting nodes functionality #4517

merged 12 commits into from
Jul 1, 2022

Conversation

Durman
Copy link
Collaborator

@Durman Durman commented Jun 9, 2022

Addressed problem description

muting_support

Now it's possible to implement sv_internal_links property for nodes which returns iterable pairs of input and output sockets of the node. The pairs will be used by update system to define how to path data through the node. The implementation is needed only if standard Blender mapping does not fit to the node logic and it looks that in many nodes it does not.

Preflight checklist

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete.
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@zeffii
Copy link
Collaborator

zeffii commented Jun 29, 2022

i'll also add this muting to snlite, allowing user to configure what happens during mute. Looking forward to this PR.

@Durman Durman marked this pull request as ready for review June 30, 2022 05:40
@Durman Durman merged commit 15972d7 into master Jul 1, 2022
@Durman Durman deleted the muting_nodes branch July 1, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants