Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos carthesian->cartesian #4622

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Aug 25, 2022

Fixes both source code and source comment

Fixes both source code and source comment
@zeffii
Copy link
Collaborator

zeffii commented Aug 26, 2022

can we merge this already? seems good.

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 26, 2022

Question here is about backward compatibility though, right?

@zeffii
Copy link
Collaborator

zeffii commented Aug 26, 2022

so far i don't see anything in the PR that would break existing .blends / .jsons , in the enum lists ( in math module, the modes lists) only the first element is stored in the .blend

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 27, 2022

alrighty then :)

@zeffii zeffii requested a review from portnov August 29, 2022 08:14
Copy link
Collaborator

@portnov portnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Durman Durman merged commit cde475f into nortikin:master Oct 5, 2022
@luzpaz luzpaz deleted the typos/carthesian branch October 5, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants