Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve Viewer Draw & Surface Viewer Draw nodes. #4652

Merged
merged 11 commits into from
Sep 12, 2022

Conversation

portnov
Copy link
Collaborator

@portnov portnov commented Sep 11, 2022

Shorthand nodes for viewing curves and surfaces in 3D View.

In my experience, I tend to use 4 nodes to inspect the curve I generated: Evaluate Curve + Viewer Draw, and Deconstruct Curve + Viewer Draw. Similarly with surfaces.

These nodes allow to replace four nodes with one.

For NURBS, the nodes can show control polygon / control net; "Viewer Draw Curve" node can also show "node points" (Greville points) of the curve.
For non-NURBS, the nodes just do not try to show these NURBS-specific things.

The nodes also have "bake" capability.

Screenshot_20220911_211123
Screenshot_20220911_210840

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@portnov portnov added the NURBS label Sep 11, 2022
@portnov
Copy link
Collaborator Author

portnov commented Sep 12, 2022

@zeffii @Durman Will it be okay if I replace existing logic of creating "Evaluate Curve / Surface" + "Viewer Draw" from context menu, with the new nodes?

@Durman
Copy link
Collaborator

Durman commented Sep 12, 2022

It would be logical. Also it seems that Ctrl + LMB could connect the new viewer to curve and surface sockets.

1) when loading (default) preset, node name can be changed, so the
   reference to the node instance is no longer valid. So when loading a
   peset, we now return the instance of newly created node.
2) When saving a preset from Shift-P menu, is_node_preset flag was not
   set, so the preset was saved in incorrect format and could not be
   loaded as a node preset.
3) Use default presets when creating temporal viewers.
@portnov portnov merged commit 303b1f6 into master Sep 12, 2022
@portnov portnov deleted the curve_surface_viewer_nodes branch September 12, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants