Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sverchok open subdiv 2 #4691

Merged
merged 10 commits into from
Oct 12, 2022
Merged

Conversation

GeneralPancakeMSTR
Copy link
Contributor

Addressed problem description

#4575 Add Catmull-Clark subdivision to Sverchok

  • Renames "OpenSubdiv" node to "Catmull-Clark Subdivision"
  • Improved stability, particularly level 0 subdivision on topology without quads is handled a lot better, along with subdivision <= 0 in general.

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@Durman
Copy link
Collaborator

Durman commented Oct 4, 2022

Now you can't change bl_idname attribute it will break previous user layouts (present of undefined nodes) . I think fixing label is enough.

@GeneralPancakeMSTR
Copy link
Contributor Author

Now you can't change bl_idname attribute it will break previous user layouts (present of undefined nodes) . I think fixing label is enough.

Good point, I will fix that.

@GeneralPancakeMSTR
Copy link
Contributor Author

I'm not sure the best way to do the node mute implementation. Currently I'm just mapping verts->verts and faces->faces, but this sort of breaks the Edge output if the user has that plugged in and mutes the node. I'm not sure what the best way to deal with that is, so if anyone has ideas, please let me know.

index.md Outdated Show resolved Hide resolved
@Durman
Copy link
Collaborator

Durman commented Oct 10, 2022

Probably there is no need to generate edges in your case.

@Durman Durman merged commit db0615e into nortikin:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants