Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alpha and beta categories. Mark nodes in development by frames. #4697

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

Durman
Copy link
Collaborator

@Durman Durman commented Oct 6, 2022

Addressed problem description

It's implementation of this proposal #4685
Now nodes in development can be marked by frames. To do this alpha or beta icon should be added to a node class.

class Node:
    sv_icon = 'SV_ALPHA`  # or 'SV_BETA`

image

I moved some (seems to me as redundant) nodes from removed categories to old nodes. Some nodes marked as Alpha/Beta nodes. I does not have strong option about whether I've made changes correct so if someone has any suggestions they are welcome.

Preflight checklist

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Ready for merge.

@portnov
Copy link
Collaborator

portnov commented Oct 6, 2022

Maybe instead of changing icon it's better to have special class property for this? like

class MyNode:
    sv_alpha = True

@Durman
Copy link
Collaborator Author

Durman commented Oct 6, 2022

Using icons has extra advantages. It's clear from menu that a node is in Alpha/Beta stage.

image

@Durman Durman marked this pull request as ready for review October 6, 2022 11:36
# Conflicts:
#	docs/nodes/modifier_change/modifier_change_index.rst
#	docs/nodes/modifier_make/modifier_make_index.rst
#	index.md
#	menu.py
#	ui/nodeview_space_menu.py
@Durman Durman merged commit 8ed55ee into master Oct 24, 2022
@Durman Durman deleted the mark_beta_nodes branch October 24, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants