"Curve Segment" node: add "NURBS if possible" flag #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4722.
Depending on NURBS implementation being used, calculation of new NURBS curve representing the segment of initial NURBS curve can give unexpected results in some special cases. So, let's add a flag to disable such calculation and fall back to trivial algorithm of just taking a subdomain of initial curve - that will return a generic Curve object instead of Nurbs, but will not depend on nurbs implementation.
Since this is useful only in rare cases, I put this flag to the N panel.
Preflight checklist
Put an x letter in each brackets when you're done this item: