Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use generic (rational) algorithm if the curve is non-rational. #4805

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Do not use generic (rational) algorithm if the curve is non-rational. #4805

merged 1 commit into from
Dec 9, 2022

Conversation

portnov
Copy link
Collaborator

@portnov portnov commented Dec 8, 2022

refs #4722.

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@portnov portnov mentioned this pull request Dec 8, 2022
Closed
@rendetto
Copy link
Contributor

rendetto commented Dec 8, 2022

@portnov I tested the speed of this PR with the setup from #4772
and now the framerate seems the same as the one before those performance drops.

Thanks a lot!

@portnov portnov merged commit 5bb19fc into master Dec 9, 2022
@portnov portnov deleted the 4722_speedup branch December 9, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
NURBS Performance 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portnov @rendetto