Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer Draw Curve: indicate curvature by colors. #4810

Merged
merged 5 commits into from
Dec 15, 2022
Merged

Viewer Draw Curve: indicate curvature by colors. #4810

merged 5 commits into from
Dec 15, 2022

Conversation

portnov
Copy link
Collaborator

@portnov portnov commented Dec 10, 2022 •
edited
Loading

Screenshot_20221211_021335

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@portnov portnov marked this pull request as draft December 10, 2022 21:16
@rendetto
Copy link
Contributor

Just a suggestion. It would be more descriptive if we can map a gradient instead of a single color.

@portnov
Copy link
Collaborator Author

portnov commented Dec 11, 2022

Yes, but then we have to configure this gradient somehow. It would complicate node's UI.

@portnov
Copy link
Collaborator Author

portnov commented Dec 11, 2022

If you really want a gradient, it's already possible with a couple of additional nodes:
Screenshot_20221210_225146

@rendetto
Copy link
Contributor

rendetto commented Dec 11, 2022 •
edited
Loading

If you really want a gradient, it's already possible with a couple of additional nodes: ![Screenshot_20221210_225146]

That's cool! Thanks a lot! :)

@portnov portnov changed the title Viewer Draw Color: indicate curvature by colors. Viewer Draw Curve: indicate curvature by colors. Dec 15, 2022
@portnov portnov marked this pull request as ready for review December 15, 2022 16:37
@portnov portnov merged commit 80cf578 into master Dec 15, 2022
@portnov portnov deleted the curvature_colors branch December 15, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portnov @rendetto