Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Nurbs birail": an option to use Gordon algorithm #4874

Closed
wants to merge 2 commits into from

Conversation

portnov
Copy link
Collaborator

@portnov portnov commented Jan 14, 2023

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@portnov portnov added the NURBS label Jan 14, 2023
@portnov portnov marked this pull request as draft January 14, 2023 21:12
@portnov
Copy link
Collaborator Author

portnov commented Sep 13, 2024

I tested this again some days ago and have found that:

  1. it works
  2. but I could not find cases where this gives more precise output than the default algorithm.

So for now I'm closing this. Anyone interested enough can try to merge this locally and try.

@portnov portnov closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant