Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Approximate NURBS Surface" node - FreeCAD implementation #4888

Merged
merged 7 commits into from
Feb 6, 2023
Merged

"Approximate NURBS Surface" node - FreeCAD implementation #4888

merged 7 commits into from
Feb 6, 2023

Conversation

rendetto
Copy link
Contributor

@rendetto rendetto commented Feb 3, 2023

This PR implements the approximation method from FreeCAD/OCCT.

It offers two approaches:

  • Parametrization with only Euclidean, Points and Centripetal metrics.

Approx_NURBS_Surface_FreeCAD_Parametrization

  • Variational Smoothing similar to the one used by "Approximate NURBS Curve" node.

Approx_NURBS_Surface_FreeCAD_VariationalSmoothing

@rendetto rendetto mentioned this pull request Feb 3, 2023
Closed
@portnov portnov added the NURBS label Feb 3, 2023
@portnov
Copy link
Collaborator

portnov commented Feb 6, 2023

Looks good to me. Should I merge this?

@rendetto
Copy link
Contributor Author

rendetto commented Feb 6, 2023

Yes. Please merge it.

@portnov portnov merged commit 2c942bd into nortikin:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
NURBS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rendetto @portnov