fix torus function torus_verts performance. #4958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nual measurement)
Durman
approved these changes
Jul 24, 2023
|
Is 1.75 boost of the particular loop or the whole work of the node? |
|
1.75 is for “for”. It is hard to compute so many sin, cos, and power. I try calc numpy. It can be speed up 1.5x. But it is very hard to read that code. |
|
Yes, numpy is a functional programming. It is something to which someone have to get used. By the way Sverchok itself also is sort of functional programming. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out some calculations from inner for.
Sverchok master, Windows 11, Blender 3.6.1
(manual measurement)
Performance up 1.75x.