-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #4705. Viewer Index+ show right text with multiple objects and indices of objects #5000
base: master
Are you sure you want to change the base?
Conversation
Hi @zeffii ! Can you test this pull request? I force to work this node in a mode with multiple objects with custom text and property "Draw Object Index" is On. But I think this node need global refactor ))) (not now) P.S. |
the ghost icon-button is for hiding backfacing indices, so only really works when user passes polygons too. |
I get this glitch after exclude draw_indices_2D. Now it is work good. |
Hi, @zeffii! May I ask you to view this PR? |
@satabol sorry , i've been traveling and have not been spending much time near computers. |
i don't see anything i disagree with, but would prefer if #4983 was pushed first. |
Ok @zeffii. No problem. I will expect it. ))) |
Sverchok 1.3.0-alpha, Blender 3.6.1, Windows 11
fix #4705
Now Modes are good:
Only indices for vertices, edges, faces without object indices
![image](https://private-user-images.githubusercontent.com/14288520/270065719-efa5f291-49e9-4b69-aa79-e54e2ff8f497.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNjU3MTktZWZhNWYyOTEtNDllOS00YjY5LWFhNzktZTU0ZTJmZjhmNDk3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEyYmM0NDc3MzUxZjg5ZDRkZWI1Nzg5ZTdhMmU0YzgzOWZmODU4NWFiY2M4M2FjYjM4ZjRjOWQ1YzRhMDI2NjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PebLbFMM1ZWHWd8aINJdZGl2uFC650a033SpHKALgbE)
![image](https://private-user-images.githubusercontent.com/14288520/270067370-f8e86635-93d9-4d43-afde-242fbf87773f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNjczNzAtZjhlODY2MzUtOTNkOS00ZDQzLWFmZGUtMjQyZmJmODc3NzNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJlY2JlNTgyODQ5MDJiODlkZTAyN2UzYjU5OGMwZmMyZTRmZGMwZjMxYzc4MjQ1YzFjZWNiZWY4YThhZTYxMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0vziHguFRpVnyd5CPqmeu5ztzOTl2y7NOi5aWRTAsBQ)
![image](https://private-user-images.githubusercontent.com/14288520/270068513-98c3bf0f-f408-4268-b7a1-e42a3e9c65ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNjg1MTMtOThjM2JmMGYtZjQwOC00MjY4LWI3YTEtZTQyYTNlOWM2NWFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdlMDNlZmI2YjRlMWQxNzJjMzFiYWZhZTkzNDhlM2MzM2VkM2U5MTY3NDkyNzRjZDRiNzI0MTRlNWNmYWU4YjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.o9vRgyjZKd8ru9UxbuZH3Uqm7lQj6sXthqEu83PG_6E)
Indices for vertices, edges, faces with (!!!) object indices
![image](https://private-user-images.githubusercontent.com/14288520/270066344-ee0298da-cef4-4850-ba06-2bef7fce8aec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNjYzNDQtZWUwMjk4ZGEtY2VmNC00ODUwLWJhMDYtMmJlZjdmY2U4YWVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTExOWEwMDU3NjBkYjc1NWJjYTRkY2Q5MzVmMzY2OWQwOGI2OGM0NDA3OTdkZDJmOGUwN2UzNDNhNWJjMjkxMWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7MvyhrjeJszA85fiAz_mVtJLDZgTuoYXJNIt1Ca3U9g)
![image](https://private-user-images.githubusercontent.com/14288520/270066733-32ad331c-22ea-40a5-8395-8a4c1f223cf1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNjY3MzMtMzJhZDMzMWMtMjJlYS00MGE1LTgzOTUtOGE0YzFmMjIzY2YxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkZDBmY2Y2MDgyMmU4YTBkYzA5ZDJiMGI0NTE3NDE0NzhhY2RkZjc0YTVmOWQ1MjIzNjBhOTdiNDM3NmJlZDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hgIYT0d0Ri_bZQc6OZ1VtBx9PURhtXkL5ROxYVbRdXw)
![image](https://private-user-images.githubusercontent.com/14288520/270068718-5b43d6e3-bc79-4d08-8908-c19fb343f485.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNjg3MTgtNWI0M2Q2ZTMtYmM3OS00ZDA4LTg5MDgtYzE5ZmIzNDNmNDg1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwNGY1YmIxN2JjMzdkNzQ4ZTNkNDA3ZmNiNDAyMmNiNWI4NmNhMjY3NWYzMTgyZjA0OWQzMDQ1OGI1MTdmMjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2tPRJ58mrIyp96YFdhEs6W0U77K8LnZmG_hPhhzPmt4)
Only text for vertices, edges, faces without object indices
![image](https://private-user-images.githubusercontent.com/14288520/270067688-64c67e53-ceeb-4b78-9425-e90f7059bb70.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNjc2ODgtNjRjNjdlNTMtY2VlYi00Yjc4LTk0MjUtZTkwZjcwNTliYjcwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVmMTIyYWIyYzBkM2MzNzY0ZTliZTQwMTUxMDZkZjk3NjNjNmVkOGY2NzJiMzUzNjQ0YzE1NTFjNzBhZjZiOWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.H8COZTCZ2-6tUmaFX8HG5aXm4Q3uRWzVzh0D9cTM-jQ)
![image](https://private-user-images.githubusercontent.com/14288520/270067851-6079a4d6-5013-46ad-852b-1eaad6c31f85.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNjc4NTEtNjA3OWE0ZDYtNTAxMy00NmFkLTg1MmItMWVhYWQ2YzMxZjg1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFjMzNjYTJiNjZhNmU4NWRkMGYzNTMzZGJlZGQxMGIzZmU0MzU4MjFkNDU5NWJlZjZkYjc4NmMyNWU5MjI5NDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.24y8z_QWibMbihzPPiHayqxoR3Dvkn3x2oPVFgnL7zw)
)
Text for vertices, edges, faces with (!!!) object indices
![image](https://private-user-images.githubusercontent.com/14288520/270074382-d4ca049d-64b0-4cf6-9e0e-fb7eb0da81ca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNzQzODItZDRjYTA0OWQtNjRiMC00Y2Y2LTllMGUtZmI3ZWIwZGE4MWNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFkNmY1YWJkZDA4OTRkYmZiNzk4N2VjYjMyMGFlOWUyNTJlYmU3YmY3ZDU1NmNiNTBhOTE5MDEyZWY1OTZiOTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Kg-faD3T_kcW6vJn2P88T8LNJkbxO_QaQMQi9hY5mI8)
![image](https://private-user-images.githubusercontent.com/14288520/270074371-fd094734-774f-4d07-ae60-e68a7dad9aea.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNzQzNzEtZmQwOTQ3MzQtNzc0Zi00ZDA3LWFlNjAtZTY4YTdkYWQ5YWVhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVmNzM2NjczZmNiNTEwYjMyNDYzNGMxZTdiMDViMTZmMDQxZDE2ZjIxN2ZjZmIzZjAwY2ZkMjk2MzgwMDlkZjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.haMxt82yU6mRQwukv6V4kJBa1OfrsIIP85A7yuianfY)
![image](https://private-user-images.githubusercontent.com/14288520/270074350-99af4054-d460-41dc-a048-0c4d03c00617.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNjA1MzMsIm5iZiI6MTcyNjE2MDIzMywicGF0aCI6Ii8xNDI4ODUyMC8yNzAwNzQzNTAtOTlhZjQwNTQtZDQ2MC00MWRjLWEwNDgtMGM0ZDAzYzAwNjE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDE2NTcxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc3MzUzNTVjYzkwZmNlYzgxOWExZTdlMWIzODEwYzA1OGJjY2U4YjU5YTBlNjg0ZDAxMmI1YWMyZjgxNWMwODgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qp17QPMaJK-H87omaIYXXIJygkmSoeVjgNJp08T6aCA)
Blend file for tests: issue_4705.example.blend.zip