Visual Studio for Mac crashes when opening Edit menu #156

shirshov · 2017-08-18T00:48:07Z

Every time I try to open Edit menu, Visual Studio crashes, when at least one source code file is open.
(VS version 7.2 build 487, but I don't think it matters)

It looks like the culprit is the following line:
https://github.com/nosami/XSVim/blob/7.0/XSVim/XSVim.fs#L43
It was introduced in this commit: bb69ad6. If I comment out "Control+I" then the crashes do not happen.

This could be because I manually reassigned CTRL-I to "Format Document", which is the default binding. I tried removing the binding using VS's Preferences dialog, but still got the crashes.

Side note:
I'm not convinced we should disable CTRL-I automatically. This is out-of-the-box binding to one of the most frequently used commands.

The text was updated successfully, but these errors were encountered:

nosami · 2017-08-20T08:56:04Z

We shouldn't disable them automatically. There should be an option on the first run to offer to disable them. I disabled them because there have been multiple comments on the issue tracker here and on stack overflow with people not knowing how to configure these (and it's not at all obvious which commands need disabling - it differs by OS for example)

What's the stack trace when it crashes?

nosami · 2017-08-20T08:57:43Z

CTRL-I is one the most frequent vim keybinds that I use by the way. And I never use format document :)

nosami · 2017-08-20T09:50:37Z

OK. Managed to reproduce in 7.1 build 1281 after reassigning Ctrl-I to Format Document

System.InvalidOperationException: Invalid action command id: MonoDevelop.Ide.CodeFormatting.CodeFormattingCommands.FormatBuffer
  at MonoDevelop.Components.Commands.CommandManager.GetCommandInfo (System.Object commandId, MonoDevelop.Components.Commands.CommandTargetRoute targetRoute, System.Threading.CancellationToken cancelToken) [0x001f9] in /Users/builder/data/lanes/4989/cc3abfe9/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Commands/CommandManager.cs:1704
  at MonoDevelop.Components.Commands.CommandManager.GetCommandInfo (System.Object commandId, MonoDevelop.Components.Commands.CommandTargetRoute targetRoute) [0x00000] in /Users/builder/data/lanes/4989/cc3abfe9/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Commands/CommandManager.cs:1594
  at MonoDevelop.Components.Mac.MDMenuItem.Update (MonoDevelop.Components.Mac.MDMenu parent, System.Int32& index) [0x00014] in /Users/builder/data/lanes/4989/cc3abfe9/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDMenuItem.cs:106
  at MonoDevelop.Components.Mac.MDMenu.UpdateCommands () [0x00037] in /Users/builder/data/lanes/4989/cc3abfe9/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDMenu.cs:150
  at MonoDevelop.Components.Mac.MDSubMenuItem.Update (MonoDevelop.Components.Mac.MDMenu parent, System.Int32& index) [0x00000] in /Users/builder/data/lanes/4989/cc3abfe9/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDSubMenuItem.cs:48
  at MonoDevelop.Components.Mac.MDMenu.UpdateCommands () [0x00037] in /Users/builder/data/lanes/4989/cc3abfe9/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDMenu.cs:150
  at MonoDevelop.Components.Mac.MDMenu.MenuNeedsUpdate (AppKit.NSMenu menu) [0x00019] in /Users/builder/data/lanes/4989/cc3abfe9/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDMenu.cs:192

nosami · 2017-08-20T10:00:43Z

Broken in 7.2 too... but everything starts to work again as soon as you delete the <C-i> binding.

I spoke to @sevoku recently about unbinding built in keybindings and he hinted that this may be improved in the future.

We shouldn't be using CommandManager.UnregisterCommand but currently there is no other way to do it than manually rebinding each command.

sevoku · 2017-08-21T07:26:47Z

@nosami as a workaround you could try to unset just the binding without messing with the CommandService. Something like this:

IdeApp.CommandService.GetCommand ("MonoDevelop.Ide.CodeFormatting.CodeFormattingCommands.FormatBuffer");
KeyBindingService.CurrentKeyBindingSet.SetBinding (cmd, new string[0]);

Additionally you could enum the bindigs for that command with KeyBindingService.CurrentKeyBindingSet.GetBindings (cmd); and remove just the conflicting one.

nosami · 2017-08-22T15:11:18Z

Thanks @sevoku! I'll try that out.

nosami · 2017-08-23T03:32:08Z

@nosami as a workaround you could try to unset just the binding without messing with the CommandService. Something like this:

IdeApp.CommandService.GetCommand ("MonoDevelop.Ide.CodeFormatting.CodeFormattingCommands.FormatBuffer");
KeyBindingService.CurrentKeyBindingSet.SetBinding (cmd, new string[0]);

@sevoku I tried this but none of the keys that I'm attempting to override can be intercepted by the vim addin.

mhutch · 2018-02-28T23:29:28Z

FWIW, maybe it would be cleaner to have a keybinding set for vim instead of modifying the current one? Or maybe prompt whether the user wants to switch?

nosami · 2018-03-01T06:24:24Z

@mhutch I'm not sure if it's possible to have a keybinding set for vim due to the many combinations of keys that can be formed to create a command.

I could make it so that the user needs to opt-in to automatic keys override though I guess.

dnlbschff · 2018-03-01T09:08:54Z

Hey, I'm having the same issue. However, I'm on a fresh install of VS 7.3.3 without any keybindings customised. Can I support you with any information to help sort out the problem?

nosami · 2018-03-01T09:26:03Z

@dnlbschff Do you get the same stack trace in the log? Help -> Open Log Directory

dnlbschff · 2018-03-01T11:47:41Z

Pretty much. The line numbers differ slightly.

System.InvalidOperationException: Invalid action command id: MonoDevelop.Ide.CodeFormatting.CodeFormattingCommands.FormatBuffer
  at MonoDevelop.Components.Commands.CommandManager.GetCommandInfo (System.Object commandId, MonoDevelop.Components.Commands.CommandTargetRoute targetRoute, System.Threading.CancellationToken cancelToken) [0x001f9] in /Users/builder/data/lanes/5402/e02ab111/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Commands/CommandManager.cs:1704 
  at MonoDevelop.Components.Commands.CommandManager.GetCommandInfo (System.Object commandId, MonoDevelop.Components.Commands.CommandTargetRoute targetRoute) [0x00000] in /Users/builder/data/lanes/5402/e02ab111/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components.Commands/CommandManager.cs:1594 
  at MonoDevelop.Components.Mac.MDMenuItem.Update (MonoDevelop.Components.Mac.MDMenu parent, System.Int32& index) [0x00014] in /Users/builder/data/lanes/5402/e02ab111/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDMenuItem.cs:108 
  at MonoDevelop.Components.Mac.MDMenu.UpdateCommands () [0x00037] in /Users/builder/data/lanes/5402/e02ab111/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDMenu.cs:157 
  at MonoDevelop.Components.Mac.MDSubMenuItem.Update (MonoDevelop.Components.Mac.MDMenu parent, System.Int32& index) [0x00000] in /Users/builder/data/lanes/5402/e02ab111/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDSubMenuItem.cs:48 
  at MonoDevelop.Components.Mac.MDMenu.UpdateCommands () [0x00037] in /Users/builder/data/lanes/5402/e02ab111/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDMenu.cs:157 
  at MonoDevelop.Components.Mac.MDMenu.MenuNeedsUpdate (AppKit.NSMenu menu) [0x00019] in /Users/builder/data/lanes/5402/e02ab111/source/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Mac/MDMenu.cs:199

(I really love the extension otherwise though!)

nosami · 2018-03-01T12:22:45Z

@dnlbschff Thanks! Although I'm pretty sure that the only way to get that stack trace is if you rebind the FormatBuffer key. Maybe you did it in a previous version of VS?

For now, you can workaround it by opening the preferences dialog before you load any solution from the Welcome Page (so that this extension doesn't get chance to load) and then just delete the keybinding for Format Document

dnlbschff · 2018-03-01T15:06:55Z

Well to be precise, I had a previous installation and removed it with the uninstall script provided by Microsoft. Now I reinstalled VS and checked again. The problem persisted, which is why I posted here.

Thanks, your hint resolved the problem. I tried that with my last install and it didn't. But I also know why now: I was using the Windows keybinding set before (because I'm more familiar with that, coming from a windows machine).

So once you switch to the Windows preset, you get the error for Format Document, Redo, Cut, etc. 😄 So manually cleaning out all those conflicting keybindings, is not something I want to do right now, which is why I left the preset at the default, with the Format Document binding removed. Thanks for your support!

nosami · 2018-03-01T15:11:48Z

Ah, I see! I'll try and come up with a solution for this soon.

mhutch · 2018-03-01T19:52:36Z

@nosami I didn't mean implementing it as keybindings, I meant have a keybinding set that doesn't conflict with the vim stuff.

nosami · 2018-03-01T19:54:38Z

@mhutch - Yeah, I guess that could work for the few ctrl-key bindings that are conflicted.

mhutch · 2018-03-01T20:36:45Z

And you could add new bindings for those commands :)

nosami · 2018-03-10T16:42:49Z

Just attempted to add a Vim keybinding set just for control-D to test out but I get conflicting shortcuts. No idea how to make this work.

Fixes #156 Create commands for all keybinds that may conflict with built in keybinding schemes (Just Visual Studio for Mac default for now). Also created Visual Studio + Vim keybinding scheme to set vim keys for users that want that behaviour.

nosami · 2018-03-19T16:36:34Z

Looks like this bug was fixed in Monodevelop itself - mono/monodevelop#4214

Should be in 7.4 service release 1.

Fixes #156 Create commands for all keybinds that may conflict with built in keybinding schemes (Just Visual Studio for Mac default for now). Also created Visual Studio + Vim keybinding scheme to set vim keys for users that want that behaviour.

shirshov added the bug label Aug 18, 2017

nosami mentioned this issue Mar 12, 2018

Don't automatically remove commands #201

Merged

nosami closed this as completed in #201 May 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Visual Studio for Mac crashes when opening Edit menu #156

Visual Studio for Mac crashes when opening Edit menu #156

shirshov commented Aug 18, 2017 •

edited

Loading

nosami commented Aug 20, 2017

nosami commented Aug 20, 2017

nosami commented Aug 20, 2017

nosami commented Aug 20, 2017 •

edited

Loading

sevoku commented Aug 21, 2017

nosami commented Aug 22, 2017

nosami commented Aug 23, 2017

mhutch commented Feb 28, 2018

nosami commented Mar 1, 2018 •

edited

Loading

dnlbschff commented Mar 1, 2018

nosami commented Mar 1, 2018

dnlbschff commented Mar 1, 2018

nosami commented Mar 1, 2018

dnlbschff commented Mar 1, 2018

nosami commented Mar 1, 2018

mhutch commented Mar 1, 2018

nosami commented Mar 1, 2018

mhutch commented Mar 1, 2018

nosami commented Mar 10, 2018

nosami commented Mar 19, 2018

Visual Studio for Mac crashes when opening Edit menu #156

Visual Studio for Mac crashes when opening Edit menu #156

Comments

shirshov commented Aug 18, 2017 • edited Loading

nosami commented Aug 20, 2017

nosami commented Aug 20, 2017

nosami commented Aug 20, 2017

nosami commented Aug 20, 2017 • edited Loading

sevoku commented Aug 21, 2017

nosami commented Aug 22, 2017

nosami commented Aug 23, 2017

mhutch commented Feb 28, 2018

nosami commented Mar 1, 2018 • edited Loading

dnlbschff commented Mar 1, 2018

nosami commented Mar 1, 2018

dnlbschff commented Mar 1, 2018

nosami commented Mar 1, 2018

dnlbschff commented Mar 1, 2018

nosami commented Mar 1, 2018

mhutch commented Mar 1, 2018

nosami commented Mar 1, 2018

mhutch commented Mar 1, 2018

nosami commented Mar 10, 2018

nosami commented Mar 19, 2018

shirshov commented Aug 18, 2017 •

edited

Loading

nosami commented Aug 20, 2017 •

edited

Loading

nosami commented Mar 1, 2018 •

edited

Loading