-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Studio for Mac crashes when opening Edit menu #156
Comments
We shouldn't disable them automatically. There should be an option on the first run to offer to disable them. I disabled them because there have been multiple comments on the issue tracker here and on stack overflow with people not knowing how to configure these (and it's not at all obvious which commands need disabling - it differs by OS for example) What's the stack trace when it crashes? |
|
OK. Managed to reproduce in 7.1 build 1281 after reassigning Ctrl-I to Format Document
|
Broken in 7.2 too... but everything starts to work again as soon as you delete the I spoke to @sevoku recently about unbinding built in keybindings and he hinted that this may be improved in the future. We shouldn't be using CommandManager.UnregisterCommand but currently there is no other way to do it than manually rebinding each command. |
@nosami as a workaround you could try to unset just the binding without messing with the
Additionally you could enum the bindigs for that command with |
Thanks @sevoku! I'll try that out. |
@sevoku I tried this but none of the keys that I'm attempting to override can be intercepted by the vim addin. |
FWIW, maybe it would be cleaner to have a keybinding set for vim instead of modifying the current one? Or maybe prompt whether the user wants to switch? |
@mhutch I'm not sure if it's possible to have a keybinding set for vim due to the many combinations of keys that can be formed to create a command. I could make it so that the user needs to opt-in to automatic keys override though I guess. |
Hey, I'm having the same issue. However, I'm on a fresh install of VS 7.3.3 without any keybindings customised. Can I support you with any information to help sort out the problem? |
@dnlbschff Do you get the same stack trace in the log? |
Pretty much. The line numbers differ slightly.
(I really love the extension otherwise though!) |
@dnlbschff Thanks! Although I'm pretty sure that the only way to get that stack trace is if you rebind the FormatBuffer key. Maybe you did it in a previous version of VS? For now, you can workaround it by opening the preferences dialog before you load any solution from the Welcome Page (so that this extension doesn't get chance to load) and then just delete the keybinding for |
Well to be precise, I had a previous installation and removed it with the uninstall script provided by Microsoft. Now I reinstalled VS and checked again. The problem persisted, which is why I posted here. Thanks, your hint resolved the problem. I tried that with my last install and it didn't. But I also know why now: I was using the Windows keybinding set before (because I'm more familiar with that, coming from a windows machine). So once you switch to the Windows preset, you get the error for |
Ah, I see! I'll try and come up with a solution for this soon. |
@nosami I didn't mean implementing it as keybindings, I meant have a keybinding set that doesn't conflict with the vim stuff. |
@mhutch - Yeah, I guess that could work for the few ctrl-key bindings that are conflicted. |
And you could add new bindings for those commands :) |
Just attempted to add a Vim keybinding set just for control-D to test out but I get conflicting shortcuts. No idea how to make this work. |
Fixes #156 Create commands for all keybinds that may conflict with built in keybinding schemes (Just Visual Studio for Mac default for now). Also created Visual Studio + Vim keybinding scheme to set vim keys for users that want that behaviour.
Looks like this bug was fixed in Monodevelop itself - mono/monodevelop#4214 Should be in 7.4 service release 1. |
Fixes #156 Create commands for all keybinds that may conflict with built in keybinding schemes (Just Visual Studio for Mac default for now). Also created Visual Studio + Vim keybinding scheme to set vim keys for users that want that behaviour.
Fixes #156 Create commands for all keybinds that may conflict with built in keybinding schemes (Just Visual Studio for Mac default for now). Also created Visual Studio + Vim keybinding scheme to set vim keys for users that want that behaviour.
Every time I try to open Edit menu, Visual Studio crashes, when at least one source code file is open.
(VS version 7.2 build 487, but I don't think it matters)
It looks like the culprit is the following line:
https://github.com/nosami/XSVim/blob/7.0/XSVim/XSVim.fs#L43
It was introduced in this commit: bb69ad6. If I comment out
"Control+I"
then the crashes do not happen.This could be because I manually reassigned
CTRL-I
to "Format Document", which is the default binding. I tried removing the binding using VS's Preferences dialog, but still got the crashes.Side note:
I'm not convinced we should disable
CTRL-I
automatically. This is out-of-the-box binding to one of the most frequently used commands.The text was updated successfully, but these errors were encountered: