Fix writing to the incorrect stream #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places, the documentation makes it clear that plugins should be able to control the output via one means or another. In some cases, setting event.handled = True prevents default output. Those cases seem to be working fine.
In other cases, you are told to wrap (or otherwise modify) the stream attached to the event to control output. This mostly works, but I found three places in nose2 that were not writing to the correct stream (they were using the default stream instead of the stream on the event), which prevents a plugin from fully controlling the output.
This pull request simply fixes three
writeln
calls to get called on the event's stream, just as the rest of the function is already doing in each case.In
_reportSummary()
I also moved the location of thewriteln
call down until after the event's stream had been set up.This is important for my particular plugin, because the whole point of the plugin is to completely change the output.