Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if tool.removeAllListeners esists before call #296

Merged
merged 1 commit into from
Jan 24, 2016

Conversation

dmytrokyrychuk
Copy link
Contributor

Some tools may not have removeAllListeners method, especially those
which do not extend EventEmitter.

Deactivating this package (Settings > Packages > build > Deactivate) leads to the following error:

Error deactivating package 'build' TypeError: tool.removeAllListeners is not a function
    at /path/to/atom-build/lib/build.js:98:12
    ...

Some tools may not have `removeAllListeners` method, espetially those
which do not extend `EventEmitter`.
@noseglid
Copy link
Owner

Awesome. thanks!

noseglid added a commit that referenced this pull request Jan 24, 2016
Check if tool.removeAllListeners esists before call
@noseglid noseglid merged commit 383de95 into noseglid:master Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants