Cycling through match errors #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build:error-match cycles through all locations found with the errorMatch regex. stderr is prioritized over stdout.
build:error-match-first (cmd-alt-h/ctrl-alt-h) jumps back to the first match error stderr is prioritized over stdout.
| @@ -135,27 +137,63 @@ module.exports = { | |||
| return value; | |||
| }, | |||
|
|
|||
| errorParse: function() { | |||
| this.match = []; | |||
| var regex = XRegExp(this.cmd.errorMatch); | |||
There was a problem hiding this comment.
Depending on the regex used the multiline flag possibly needs to be added. But for my quick and dirty test regex for g++ it is not needed.
|
This looks great. Would you mind adding some tests to this? |
|
I hope these tests are fine, it's the first time creating some for me. It tests cycling and wrap around and jumping to the first error match. I don't know why travis failed. In my own repo the build and test are without error. |
|
I just re-started the build. Seems as there was an outage in the travis service. |
|
Thanks you very much for this contribution. It will make an excellent addition to atom-build! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only allowing to jump to the first location found by the given errorMatch regular expression, you can cycle through every error with build:error-match. At the end it loops around to the beginning.
build:error-match-first (cmd-alt-h) jumps directly back to the beginning.