-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build:toggle-view command #60
Conversation
I guess the shortcut should be changed, currently it makes build:trigger wait for the second key press for a little while before building. |
I like this! It's smart to use I've recently made some changes on how visibility is set (due to #62). Is this compatible with those changes?? |
if (this.isAttached()) { | ||
this.detach(true); | ||
} else { | ||
this.attach(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
force flag has been added to attach as well in commit cc66db0 this must be passed here as well.
Also, I think this can be written neater by
this.isAttached() ? this.detach(true) : this.attach(true);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that one looks better, yeah. Though I've mostly seen the ternary operator used when something is actually being returned (i.e. as part of an expression).
I tested it, and it almost works. Thanks for the effort in implementing this! |
This command allows you to show or hide the build view. The default shortcut is `cmd-alt-b cmd-alt-v` (Mac) or `ctrl-alt-b ctrl-alt-v` (others).
Should I also rename this to |
Or build panel (the thing we show is internally called a Also, other config variables refer to it as |
OK, done. |
Excellent. Great job! I will include it in the next version |
Add build:toggle-view command
This command allows you to show or hide the build view. The default shortcut is
cmd-alt-b cmd-alt-v
(Mac) orctrl-alt-b ctrl-alt-v
(others).