-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error auto parse #90
Error auto parse #90
Conversation
update from main repo
Merge Main Code
Merge changes from base
This looks good! Could you also add a test for this? |
I think the test should be fine this way. |
|
||
atom.config.set('build.scrollOnError', true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably not be here.
You should also set it to the default value in the beforeEach
(which is false in this case).
Excellent. Just a minor review comment then we're good to merge! |
Fixed my copy and paste error and added the default config in the beforeEach. Edit: |
|
||
atom.config.set('build.scrollOnError', false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line shouldn't be here at all.
Since waitsFor and runs are async, this line will reset the configuration to false before your test even runs.
After putting the configuration setting in beforeEach
, we've made sure each test always start from the same fixture. There's no need to "reset" the configuration here.
Ah, now I understand. That is the problem of working at two in the night 😄 |
Splendied! Thank you so much for this! |
Added config to automatically parse and scroll to the first matched error after a build fails.