Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAME should retry to fetch the manifest when the serialization fails #8

Closed
Symbianx opened this issue Jul 19, 2017 · 0 comments · Fixed by #15
Closed

NAME should retry to fetch the manifest when the serialization fails #8

Symbianx opened this issue Jul 19, 2017 · 0 comments · Fixed by #15
Labels
Milestone

Comments

@Symbianx
Copy link
Contributor

In some cases, when fetching a dependency manifest, said dependency may return a 200 status code even if NAME is not listening in that endpoint. Currently NAME fails to deserialize the manifest from the response and fails for that dependency.

Changes:

Before deserializing the manifest, NAME should look at the returned X-NAME-Manifest-Endpoint header and check if the requested endpoint was the same as the header, if true, it should deserialize the manifest. Otherwise it should abort and try to get the manifest from the correct endpoint.

@Symbianx Symbianx added the bug label Jul 19, 2017
@Symbianx Symbianx added this to the 1.0.1 milestone Jul 19, 2017
Symbianx pushed a commit that referenced this issue Jul 27, 2017
Symbianx pushed a commit that referenced this issue Jul 27, 2017
Symbianx added a commit that referenced this issue Jul 28, 2017
* fixes #14 and fixes #8

* Added tests for #8 and #14

* Fixed NAME trying to get manifest from wrong endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant