-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cluster: fix closing dgram sockets in cluster workers throws errors
This fixes closing dgram sockets right after binding in cluster workers will throws `ERR_SOCKET_DGRAM_NOT_RUNNING` errors. PR-URL: nodejs/node#43709 Fixes: nodejs/node#40671 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
- Loading branch information
Showing
2 changed files
with
33 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
'use strict'; | ||
// Ensure that closing dgram sockets in 'listening' callbacks of cluster workers | ||
// won't throw errors. | ||
|
||
const common = require('../common'); | ||
const dgram = require('dgram'); | ||
const cluster = require('cluster'); | ||
if (common.isWindows) | ||
common.skip('dgram clustering is currently not supported on windows.'); | ||
|
||
if (cluster.isPrimary) { | ||
for (let i = 0; i < 3; i += 1) { | ||
cluster.fork(); | ||
} | ||
} else { | ||
const socket = dgram.createSocket('udp4'); | ||
|
||
socket.on('error', common.mustNotCall()); | ||
|
||
socket.on('listening', common.mustCall(() => { | ||
socket.close(); | ||
})); | ||
|
||
socket.on('close', common.mustCall(() => { | ||
cluster.worker.disconnect(); | ||
})); | ||
|
||
socket.bind(0); | ||
} |