Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Update SvelteLDClient to use proxy for flag variations. Allows to track flag evaluations #3

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

nosnibor89
Copy link
Owner

This pull request includes several significant changes to the SvelteLDClient in the svelte SDK package. The changes focus on improving the handling of flag variations, updating dependencies, and adding a new proxy mechanism for flag access.

Improvements to flag variation handling:

  • packages/sdk/svelte/src/lib/client/SvelteLDClient.ts: Added a new toFlagsProxy function to create a proxy for the flags object, which intercepts access to flag values and returns the appropriate variation. This ensures that the flag values are correctly fetched from the LaunchDarkly client.

Updates to dependencies:

Enhancements to test cases:

Refactoring for consistency:

@nosnibor89 nosnibor89 merged commit 00380bb into feat/svelte-sdk Nov 29, 2024
@nosnibor89 nosnibor89 deleted the feat/svelte-sdk-refactor-is-on branch December 2, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant