refactor: update SvelteLDClient to use compat SDK and improve initial… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization with user context
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
SvelteLDClientand its associated tests and dependencies. The key changes involve updating the initialization of the LaunchDarkly client to include a user context, modifying the imports to use the compatibility layer, and updating dependencies in thepackage.jsonfile.Changes to the SvelteLDClient and Tests:
Updated the initialization of the LaunchDarkly client to include a user context. This change affects multiple test cases to ensure the context is passed correctly. (
packages/sdk/svelte/__tests__/lib/client/SvelteLDClient.test.ts) [1] [2] [3] [4] [5] [6] [7]Modified imports to use the compatibility layer of the LaunchDarkly SDK. This change ensures compatibility with the current version of the SDK. (
packages/sdk/svelte/__tests__/lib/client/SvelteLDClient.test.ts,packages/sdk/svelte/src/lib/client/SvelteLDClient.ts) [1] [2]Dependency Updates:
package.jsonfile to their latest versions, includingsvelte,vite, andvitest. These updates ensure the project uses the latest features and security patches. (packages/sdk/svelte/package.json) [1] [2] [3]Code Enhancements:
initializefunction inSvelteLDClient.tsto accept and properly handle the user context. This change ensures that the LaunchDarkly client is initialized with the correct context and improves the handling of flag values. (packages/sdk/svelte/src/lib/client/SvelteLDClient.ts) [1] [2]