Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of <ul> Lists #179

Closed
panoramix360 opened this issue Dec 12, 2018 · 6 comments
Closed

Implementation of <ul> Lists #179

panoramix360 opened this issue Dec 12, 2018 · 6 comments
Assignees
@panoramix360
Labels
enhancement New feature or request

Comments

@panoramix360
Copy link

I'm making <ul> lists implementation, and will use this issue to PR.

As soon as I have some prototype I'll post here!
@BcRikko BcRikko added the enhancement New feature or request label Dec 12, 2018
@panoramix360
Copy link
Author

panoramix360 commented Dec 12, 2018 •
edited
Loading

I already made these two examples, what do you guys think?

image

EDIT:
One more example.
image

panoramix360 pushed a commit to panoramix360/NES.css that referenced this issue Dec 12, 2018
feat(component): Inserting lists with examples
2e4ff79 
Inserting tag <ul> to implment list, with two examples

nostalgic-css#179
panoramix360 pushed a commit to panoramix360/NES.css that referenced this issue Dec 12, 2018
feat(component): Inserting one more example list
4fd118f 
Inserting a pointer list to the lists component

nostalgic-css#179
@BcRikko
Copy link
Member

BcRikko commented Dec 12, 2018

I prefer ◆ 😍

because, ▶ is similar to the Radio button. 🤔
and > is similar to the Blockquote 🤔

@panoramix360
Copy link
Author

panoramix360 commented Dec 12, 2018 •
edited
Loading

Did you have another idea for another icon?

EDIT:
I made this more generics lists.
image

panoramix360 pushed a commit to panoramix360/NES.css that referenced this issue Dec 12, 2018
docs(storybook): Insertng lists on storybook
4f40d70 
Inserting all configuration of lists in storybook

nostalgic-css#179
panoramix360 pushed a commit to panoramix360/NES.css that referenced this issue Dec 12, 2018
feat(component): Changing lists
54765ee 
Changing lists to more generic design

nostalgic-css#179
panoramix360 pushed a commit to panoramix360/NES.css that referenced this issue Dec 12, 2018
docs(storybook): Inserting examples on storybook
22657a9 
Inserting all examples created on storybook

nostalgic-css#179
@BcRikko
Copy link
Member

BcRikko commented Dec 13, 2018 •
edited
Loading

I like ◆ and ◇ 😍

I think that ■ is not absolutely necessary 🤔

@panoramix360
Copy link
Author

Maybe haha, I just followed the convention!

But ok! I already put it on storybook, I'll make a PR 😀

panoramix360 pushed a commit to panoramix360/NES.css that referenced this issue Dec 13, 2018
feat(component): Changing examples
2de0fb6 
Changing lists examples to only two

nostalgic-css#179
panoramix360 pushed a commit to panoramix360/NES.css that referenced this issue Dec 13, 2018
docs(storybook): updating storybook
0d89cbf 
updating storybook to implement the two final lists

nostalgic-css#179
@panoramix360
Copy link
Author

PR on develop #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panoramix360 panoramix360

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panoramix360 @BcRikko