Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Mixed content on demo site #196

Closed
BcRikko opened this issue Dec 18, 2018 · 1 comment · Fixed by #198
Closed

Bug: Mixed content on demo site #196

BcRikko opened this issue Dec 18, 2018 · 1 comment · Fixed by #198
Assignees
@BcRikko
Labels
bug Something isn't working released

Comments

@BcRikko
Copy link
Member

BcRikko commented Dec 18, 2018

Describe the bug
Demo site has error that mixed content.

To Reproduce
Open demo site.

Expected behavior
No error is displayed on demo site.

Screenshots
2018-12-18 23 01 13

Environment:

  • OS: macOS
  • Browser: Chrome
  • Build environment (i.e. NodeJS):

Suggestion(s) for fixing this issue
Use https instead of http.
https://www.gravatar.com/avatar

NES.css/index.html

Lines 102 to 109 in 72bb45d

<img src="http://www.gravatar.com/avatar" class="nes-avatar is-small">
<img src="http://www.gravatar.com/avatar" class="nes-avatar">
<img src="http://www.gravatar.com/avatar" class="nes-avatar is-medium">
<img src="http://www.gravatar.com/avatar" class="nes-avatar is-large">
<img src="http://www.gravatar.com/avatar" class="nes-avatar is-small is-rounded">
<img src="http://www.gravatar.com/avatar" class="nes-avatar is-rounded">
<img src="http://www.gravatar.com/avatar" class="nes-avatar is-medium is-rounded">
<img src="http://www.gravatar.com/avatar" class="nes-avatar is-large is-rounded">

Additional context
@BcRikko BcRikko added the bug Something isn't working label Dec 18, 2018
@BcRikko BcRikko self-assigned this Dec 18, 2018
BcRikko added a commit that referenced this issue Dec 18, 2018
@BcRikko
fix(index.html): use https instead of http
efd1dfd 
fix #196
@BcRikko BcRikko mentioned this issue Dec 18, 2018
Merged
guastallaigor added a commit that referenced this issue Dec 18, 2018
@guastallaigor
Merge pull request #198 from nostalgic-css/mixed-content
a5f6091 
[#196] use https instead of http
@BcRikko
Copy link
Member Author

BcRikko commented Dec 18, 2018

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BcRikko BcRikko

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#196] use https instead of http nostalgic-css/NES.css
2 participants
@BcRikko @guastallaigor