Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use data URIs for cursors? #207

Closed
trezy opened this issue Dec 18, 2018 · 1 comment · Fixed by #266
Closed

Use data URIs for cursors? #207

trezy opened this issue Dec 18, 2018 · 1 comment · Fixed by #266
Assignees
@trezy
Labels
discussion Discussion of changes or bikeshedding enhancement New feature or request released

Comments

@trezy
Copy link
Member

trezy commented Dec 18, 2018

Is your feature request related to a problem? Please describe.
Currently our cursors are pointed to our Unpkg URLs, which isn't awesome, as the links may change from version to version.

Describe the solution you'd like
I'd be pretty stoked if we could use data URIs instead of URLs to get the cursor images.
@trezy trezy added enhancement New feature or request discussion Discussion of changes or bikeshedding labels Dec 18, 2018
@trezy trezy self-assigned this Dec 18, 2018
trezy added a commit that referenced this issue Jan 30, 2019
@trezy
refactor(cursors): Use data-uris for cursors
1b0db4a 
I've switched us from using `file-loader` to `url-loader`. This will automatically convert local URL
imports to data URIs, which means the framework no longer needs to load them from a remote URL.

#207
@trezy trezy mentioned this issue Jan 30, 2019
Merged
@BcRikko
Copy link
Member

BcRikko commented Feb 16, 2019

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

trezy added a commit that referenced this issue May 22, 2019
@trezy
refactor: convert local images to data URIs
86f7687 
I’ve added a SCSS function that, when passed a file path, will inject the file as a data URI. This
is super helpful since it ensures that the cursor images will always be available for the CSS. This
issue currently prevents the npm version of the library from being usable at all.

#207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trezy trezy

Labels
discussion Discussion of changes or bikeshedding enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(cursors): Use data-uris for cursors nostalgic-css/NES.css
2 participants
@trezy @BcRikko