Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Button is-disabled is able to click now #240

Closed
guastallaigor opened this issue Jan 3, 2019 · 1 comment · Fixed by #243
Closed

Bug: Button is-disabled is able to click now #240

guastallaigor opened this issue Jan 3, 2019 · 1 comment · Fixed by #243
Assignees
@guastallaigor
Labels
bug Something isn't working released

Comments

@guastallaigor
Copy link
Member

Describe the bug
The button is-disabled is able to click now.

To Reproduce

Steps to reproduce the behavior:

  1. Go to storybook or index.html
  2. Click on is-disabled button
  3. You are able to click on it even if the cursor is not-allowed and the css button click effect is presented.

Expected behavior
Should not be clicked just like it is on master.

Screenshots
image

Environment:

  • OS: Ubuntu 18.04
  • Browser: Chrome 71.0
  • Build environment (i.e. NodeJS): Node v9.11.1

Suggestion(s) for fixing this issue
Comparing it to master, the sizes are also different I think.

Additional context
N/A
@guastallaigor guastallaigor added bug Something isn't working good first issue Good for newcomers labels Jan 3, 2019
guastallaigor added a commit that referenced this issue Jan 4, 2019
@guastallaigor
fix(buttons): fix is-disabled button state being able to click
2c83f51 
#240
@guastallaigor guastallaigor mentioned this issue Jan 4, 2019
Merged
@guastallaigor guastallaigor self-assigned this Jan 4, 2019
@guastallaigor guastallaigor removed the good first issue Good for newcomers label Jan 4, 2019
@BcRikko
Copy link
Member

BcRikko commented Feb 16, 2019

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guastallaigor guastallaigor

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(buttons): fix is-disabled button state being able to click nostalgic-css/NES.css
2 participants
@BcRikko @guastallaigor