Add btn-extra-pixelize class

[loo41]

btn-dot

• I added a class btn-dot to make button look better
• I'm using box-shadow to see if it fits the project better

What do you think?
#87

[abdallahalsamman]

@loo41 can we find a more descriptive and clear name for btn-dot?

Maybe btn-extra-pixelize or btn-pixelize?

[loo41]

Okay, I'll change it to btn-extra-pixelize

[vandie]

Following convention for css classes, as it's a variation, shouldn't it be btn--extra-pixelize or btn--pixelize.

BEM should really be followed for CSS. (https://css-tricks.com/bem-101/) This ensures a consistant class naming system that would help maintance.

EDIT: Just checked the actual code. Apparently, this doesn't follow BEM at all right now. I'll create and Pull Request for that. I guess it's up to @BcRikko.

[abdallahalsamman]

@BcRikko BEM concepts look good, I think we should look into them 👍

@vandie thanks for bringing this up :)

[vandie]

@evexoio I've created the BEM stuff as a separate issue. Will take a look tonight to see if I can create a PR to change it.

[abdallahalsamman]

@vandie wait, I don't know if we're going to take BEM seriously yet. @BcRikko is more on the css side of things so he knows best if BEM fits NES.css or not 🙏

[vandie]

@evexoio of course.

[BcRikko]

BEM design is powerful 💪
but BEM is not my favorite, because class name gets longer 😅

I'm affected by bulma, so like SMACSS design is adopted in this project. 📝

[jjspace]

@BcRikko I personally kinda like BEM since i've started using recently but it doesn't really matter in either direction. The thing that matters is that we are all consistent in our naming. It would be good to add a section to the README under development telling everyone what standard we are using so everyone knows from the start

[BcRikko]

Ok 👍

When we publish storybook, I think that the problem about the naming convention will be solved 🎉

[abdallahalsamman]

This is continued at #105 (comment)

[BcRikko]

I confirmed 🔍
It's ok with the following code 👍

.btn {
  ...
  border: none;
  ...
}

[abdallahalsamman]

@BcRikko @jjspace can someone open a PR please?

[BcRikko]

I'll fix it 👍

[BcRikko]

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀