Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(breaking changes)Add prefix to class name #82

Merged
merged 8 commits into from
Dec 10, 2018
Merged

(breaking changes)Add prefix to class name #82

merged 8 commits into from
Dec 10, 2018

Conversation

BcRikko
Copy link
Member

@BcRikko BcRikko commented Dec 5, 2018 •
edited
Loading

⚠️ Breaking changes ⚠️

close #6

🙏 Please marge #133 first. next, I'll fix this PR(style.css). 🙏

@BcRikko
feat: add prefix to class name
f7e1801 
BREAKING CHANGE: nes- is added to class name prefix

fix #6
@BcRikko BcRikko added enhancement New feature or request breaking Breaking changes improvement and removed enhancement New feature or request labels Dec 5, 2018
@BcRikko BcRikko self-assigned this Dec 5, 2018
@BcRikko BcRikko requested review from a team and removed request for a team December 9, 2018 00:03
@BcRikko BcRikko changed the title (breaking changes)Add prefix to class name [WIP](breaking changes)Add prefix to class name Dec 9, 2018
@trezy
Copy link
Member

trezy commented Dec 9, 2018

@BcRikko The other 2 PRs you requested to have finished before this one are now taken care of. 😉

@trezy trezy added enhancement New feature or request and removed improvement labels Dec 9, 2018
@abdallahalsamman
Copy link
Member

@trezy thanks.

@BcRikko can you fix the conflicts please?

@BcRikko
Copy link
Member Author

BcRikko commented Dec 9, 2018

Tasks still remains. I'll do it today 👍
please wait a moment 🙇

@BcRikko BcRikko changed the title [WIP](breaking changes)Add prefix to class name (breaking changes)Add prefix to class name Dec 10, 2018
@BcRikko
Copy link
Member Author

BcRikko commented Dec 10, 2018

I did it 🛠

abdallahalsamman
abdallahalsamman approved these changes Dec 10, 2018
View reviewed changes
Copy link
Member

@abdallahalsamman abdallahalsamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goood 🙌🙌

@abdallahalsamman abdallahalsamman merged commit 73b3616 into develop Dec 10, 2018
@abdallahalsamman abdallahalsamman deleted the add-prefix branch December 10, 2018 08:56
@BcRikko BcRikko mentioned this pull request Dec 10, 2018
Merged
@nostalgic-css nostalgic-css deleted a comment from tlynetteb Dec 10, 2018
@nostalgic-css nostalgic-css deleted a comment from tlynetteb Dec 10, 2018
@nostalgic-css nostalgic-css deleted a comment from BcRikko Dec 10, 2018
@BcRikko
Copy link
Member Author

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@guastallaigor guastallaigor mentioned this pull request Dec 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdallahalsamman abdallahalsamman abdallahalsamman approved these changes

Assignees

@BcRikko BcRikko

Labels
breaking Breaking changes enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prefix to class name
3 participants
@BcRikko @trezy @abdallahalsamman