deprecate the color_u8! macro and make methods const
#818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrgani
force-pushed
the
const-float-colors
branch
from
96f782b
to
fb0609e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Rust 1.82,
const_fn_floating_point_arithmeticis stable (see rust-lang/rust#57241).This means that
Color::from_rgbacan beconstand thecolor_u8!macro is not required anymore.Color::from_rgba_f32was added too since the macro allowed passingf32as well asu8(or anything else, actually).Note that this should only be merged after the release of 1.82.