Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WASM time to now #96

Merged
merged 1 commit into from
May 16, 2020
Merged

Rename WASM time to now #96

merged 1 commit into from
May 16, 2020

Conversation

tversteeg
Copy link
Contributor

@tversteeg tversteeg commented May 16, 2020

This allows my PR to the instant library to work out of the box without any manual patches to the JS files: sebcrozet/instant#14

It's also more consistent with the API itself since the Rust calling function is also now().

As an aside the following can be added to your Cargo.toml to work with libraries depending on instant before the PR is merged:

[patch.crates-io]
instant = { git = "https://github.com/tversteeg/instant.git" }

@not-fl3
Copy link
Owner

not-fl3 commented May 16, 2020

Nice, thanks!

@not-fl3 not-fl3 merged commit fe984fb into not-fl3:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants