Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequel adapter #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sequel adapter #89

wants to merge 2 commits into from

Conversation

jfirebaugh
Copy link

I added a Sequel adapter.

Since Sequel doesn't support deferred associations natively, the adapter is slightly more complex than the ActiveRecord adapter.

@matthauck
Copy link

Is it possible to get this merged in? It would be really nice to have Sequel support in machinist...

@benhoskings
Copy link
Collaborator

This would be better packaged as a separate gem, perhaps machinist-sequel—it's cleanly independent of machinist core and this way, the mainenance of one won't affect the other.

@matthauck
Copy link

Seeing as ActiveRecord is supported as an adapter already, and not really part of the "core", is it not reasonable to have Sequel also supported in the main gem?

@benhoskings
Copy link
Collaborator

Well, activerecord should be moved to a separate gem too, but that's a separate job :)

Since the two concerns can be cleanly separated I think separate gems would be better.

On 28/01/2013, at 6:07 PM, Matt Hauck notifications@github.com wrote:

Seeing as ActiveRecord is supported as an adapter already, and not really part of the "core", is it not reasonable to have Sequel also supported in the main gem?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants