Merge pull request #1201 from riyazdf/pkcs-padding-comment

pkcs8: add comment about padding during unmarshal
notaryproject · Jul 25, 2017 · 5b49fb6 · 5b49fb6
2 parents 4995826 + 943d9af
commit 5b49fb6
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/tuf/utils/pkcs8.go b/tuf/utils/pkcs8.go
@@ -226,6 +226,7 @@ func ParsePKCS8ToTufKey(der []byte, password []byte) (data.PrivateKey, error) {
 		mode := cipher.NewCBCDecrypter(block, iv)
 		mode.CryptBlocks(encryptedKey, encryptedKey)
 
+		// no need to explicitly remove padding, as ASN.1 unmarshalling will automatically discard it
 		key, err := parsePKCS8ToTufKey(encryptedKey)
 		if err != nil {
 			return nil, errors.New("pkcs8: incorrect password")