Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passphrase attempt and errorring logic for keys could be improved #812

Closed
riyazdf opened this issue Jul 1, 2016 · 0 comments
Closed

Passphrase attempt and errorring logic for keys could be improved #812

riyazdf opened this issue Jul 1, 2016 · 0 comments
Milestone

Comments

@riyazdf
Copy link
Contributor

riyazdf commented Jul 1, 2016

I was doing some local testing when I realized that it's possible to fail > attempts times on passphrases that are too short, but then notary will fail with ErrAttemptsExceeded after inputting a valid passphrase. While most users may not run into this exact failure case, I think we could revisit and improve the passphrase attempt logic UX at the KeyStore level in general

🐳 $ bin/notary init repo
Root key found, using: 4327a8deba2cae19a4b393d2c6cf3a2f349652c84bc41bc1e09ade182d86b19a
Enter passphrase for root key with ID 4327a8d:
Enter passphrase for new targets key with ID f511f86 (repo):
Passphrase is too short. Please use a password manager to generate and store a good random passphrase.
Enter passphrase for new targets key with ID f511f86 (repo):
Passphrase is too short. Please use a password manager to generate and store a good random 
...
[truncated]
...
Enter passphrase for new targets key with ID f511f86 (repo):
Passphrase is too short. Please use a password manager to generate and store a good random passphrase.
Enter passphrase for new targets key with ID f511f86 (repo):
Repeat passphrase for new targets key with ID f511f86 (repo):

* fatal: failed to add key to filestore: maximum number of passphrase attempts exceeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants