Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running in CI system (no TTY) give up on passphrase #899

Closed
dhiltgen opened this issue Aug 6, 2016 · 3 comments
Closed

When running in CI system (no TTY) give up on passphrase #899

dhiltgen opened this issue Aug 6, 2016 · 3 comments

Comments

@dhiltgen
Copy link

dhiltgen commented Aug 6, 2016

When running in a CI system where no TTY is attached, if something goes wrong, notary winds up asking for a root pass phrase over and over without end. We recently had our CI system run out of disk space due to gig's of logs with the repeating pattern:

Enter passphrase for new root key with ID fdd4003: 
Enter passphrase for new root key with ID fdd4003: 
Enter passphrase for new root key with ID fdd4003: 

Notary should be smarter and give up asking for a passphrase when there's no tty instead of looping.

@endophage
Copy link
Contributor

It should give up after 10(?) retries. But if enabled, the password should be in the environment anyway.

i.e. Either there should be a password, or it shouldn't be enabled. If you're running in some other configuration it would be useful to us to understand what the use case is.

@endophage
Copy link
Contributor

Ok, there's a bug with the 10 retries that I thought had been fixed so we've moved this issue into scope #812

We'll also take a look at detecting if there's no terminal attached.

@dhiltgen
Copy link
Author

The scenario where I hit this was using delegation and I forgot to add the delegation key to a new repository that was created.

@cyli cyli added this to the Notary 0.4 milestone Aug 10, 2016
@riyazdf riyazdf self-assigned this Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants