Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add changefeed tests from endophage/notary fork #1293

Merged
merged 7 commits into from
Jan 29, 2018
Merged

add changefeed tests from endophage/notary fork #1293

merged 7 commits into from
Jan 29, 2018

Conversation

dockersid
Copy link
Contributor

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "changefeed_tests_updated" git@github.com:dockersid/notary.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842357008576
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

dockersid and others added 7 commits January 24, 2018 16:11
@dockersid
add testchangefeed.py file from endophage/notary fork
2793351 
Signed-off-by: Siddhartha Karthik Copesetty <sid@docker.com>
@riyazdf @dockersid
verify is not offline, so provide it with creds
6d8873e 
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
@dockersid
add password flag as a command line argument
646ec54 
Signed-off-by: Siddhartha Karthik Copesetty <sid@docker.com>
@dockersid
update notary package name
688fb31 
Signed-off-by: Siddhartha Karthik Copesetty <sid@docker.com>
@dockersid
pass existing bufio reader to getUsername function
1b8d671 
Signed-off-by: Siddhartha Karthik Copesetty <sid@docker.com>
@dockersid
update username flag help text
ea346e9 
Signed-off-by: Siddhartha Karthik Copesetty <sid@docker.com>
@dockersid
update script usage example
f82a3bc 
Signed-off-by: Siddhartha Karthik Copesetty <sid@docker.com>
@dockersid dockersid force-pushed the changefeed_tests_updated branch from 2a4abf6 to f82a3bc Compare January 25, 2018 00:19
@endophage
Copy link
Contributor

LGTM pending circleci

@endophage
Copy link
Contributor

@ecordell @riyazdf this is an additional integration test script and fixing an issue we had in scripting the notary server login challenge. Please take a look if you have time.

@endophage endophage mentioned this pull request Jan 25, 2018
Closed
riyazdf
riyazdf reviewed Jan 28, 2018
View reviewed changes
Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests LGTM but note that this isn’t being run by CircleCI. This should be merged into testclient.py

@endophage endophage merged commit f234167 into notaryproject:master Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riyazdf riyazdf riyazdf left review comments

@endophage endophage endophage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dockersid @GordonTheTurtle @endophage @riyazdf