-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extracting pkcs11 implementation from notary and replacing it with RPC interface #1465
Conversation
Can one of the admins verify this patch? |
I have an example implementation of an adapter in this repositorys: The PKCS11 Tests currently only pass for the externalstore package. All other pkcs11 tests with go test fail because the credentials are not included. |
resolves notaryproject#1289 Signed-off-by: Florian Eichin <florian.eichin@gmail.com>
resolves notaryproject#1289 Signed-off-by: Florian Eichin <florian.eichin@gmail.com>
resolves notaryproject#1289 Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
78a0b1c
to
24a6276
Compare
@justincormack Hey, i rebased the PR to upstream. Any news on this? |
@jschintag I'd like to test your patch. How do I select the usage of an opencryptoki token for a specific role? Does it get automatically selected only for 'root' if available, as for the Yubikey? I haven't seen any new CLI option, therefore I suppose that it works automatically. |
@Silvanoc The patch works by replacing yubikey with an RPC interface. So instead of calling the HMS directly, notary will call the interface. So which HMS you are using depends on which Adapter you are running as a daemon. As mentioned above i have example imlementations for opencryptoki (https://github.com/jschintag/notary-opencryptoki-adapter) and yubikey (https://github.com/jschintag/notary-yubikey-adapter) |
What is the benefit from switching from PKCS11, a very standard cryptographic interface, to RPC? If someone wants to integrate their RPC-enabled cryptograhic token, they can just provide a PKCS11 library to do so. However, forcing all other cryptographic tokens to have an RPC implementation/wrapper is just requiring more work for other use cases. |
I'm closing this PR since it is quite old and never really received attention from the maintainers |
This PR extracts the pkcs11 HSM implementation from notary and replaces it with an RPC interface.
New HSM implementations can now implement their own adapter independent from notary through using the RPC interface.
Closes #1289