Wait for indexes in rethink table.wait #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
|
@riyazdf Thanks for noticing this! And this LGTM! And sure, unit tests would be great. I'm not sure how to trigger indexes being slow to create, though. |
|
LGTM, good find! I'm wondering if we can use a test wrapper for rethink that creates the indexes one by one with random delays between them? Work for a later time if it's even possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should call indexWait in addition to just the table wait to ensure that all indexes for the table are ready.
I can add unit-tests to the infrastructure in #824, though the rethink integration test checks out
Signed-off-by: Riyaz Faizullabhoy riyaz.faizullabhoy@docker.com