Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implements VerifyBlob functionality #394

Merged
merged 55 commits into from
Jun 27, 2024
Merged

feat: Implements VerifyBlob functionality #394

merged 55 commits into from
Jun 27, 2024

Conversation

priteshbandi
Copy link
Contributor

@priteshbandi priteshbandi commented Apr 2, 2024 •
edited
Loading

This PR implements VerifyBlob functionality as per https://github.com/notaryproject/specifications/blob/main/specs/trust-store-trust-policy.md

This PRis ready for review

@priteshbandi priteshbandi marked this pull request as draft April 2, 2024 04:31
priteshbandi and others added 7 commits April 2, 2024 09:52
@priteshbandi
fix: Add contract version to plugin sign request and plugin verify re…
3a48859 
…quest (notaryproject#390)

Add contract version to plugin sign request and plugin verify request.
As per [specification](https://github.com/notaryproject/specifications/blob/main/specs/plugin-extensibility.md) `contractVersion` is a mandatory field.

Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@Two-Hearts @priteshbandi
bump: bump golang and dependency versions (notaryproject#392)
1caa9bc 
bumping up oras-go to v2.5.0 along with golang version to v1.21.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@dependabot @priteshbandi
build(deps): bump actions/stale from 8 to 9 (notaryproject#391)
79ffe18 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
Verify blob
fae8a83 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
stash
a4feb7d 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
some more
2cdf4a2 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
some more
8f6a3c9 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
Merge branch 'main' into BlobVerify
560fc53 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
fix commit
be64a9e 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
fix commit
f274638 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
fix commit
0593ee0 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
fix commit
9b11321 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi priteshbandi marked this pull request as ready for review April 2, 2024 18:11
@priteshbandi
fix commit
165867b 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 85.05747% with 52 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (9ff1891) to head (e201168).
Report is 24 commits behind head on main.

Files Patch % Lines
verifier/verifier.go 71.90% 25 Missing and 9 partials ⚠️
verifier/trustpolicy/oci.go 90.00% 5 Missing and 4 partials ⚠️
verifier/trustpolicy/trustpolicy.go 92.72% 3 Missing and 1 partial ⚠️
verifier/trustpolicy/blob.go 93.61% 2 Missing and 1 partial ⚠️
notation.go 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   73.43%   80.29%   +6.86%     
==========================================
  Files          24       33       +9     
  Lines        2507     2340     -167     
==========================================
+ Hits         1841     1879      +38     
+ Misses        526      324     -202     
+ Partials      140      137       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@priteshbandi
fix commit
e0d0f70 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Two-Hearts
Two-Hearts reviewed Apr 3, 2024
View reviewed changes
dir/path.go Outdated Show resolved Hide resolved
dir/path.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Outdated Show resolved Hide resolved
verifier/trustpolicy/trustpolicy.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Show resolved Hide resolved
@priteshbandi
fix commit
9d1bad5 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
priteshbandi and others added 8 commits June 23, 2024 22:06
@priteshbandi @Two-Hearts
Update notation.go
a294c53 
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi @Two-Hearts
Update verifier/trustpolicy/blob.go
0bc9e34 
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi @Two-Hearts
Update verifier/trustpolicy/oci.go
56bd3a9 
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi @Two-Hearts
Update verifier/verifier.go
7590d6c 
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
PR feedback 1
961bdbd 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
feedback 2
dd2d5a7 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
feedback 3
b47d33f 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
feedback 4
0733f7b 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
JeyJeyGao
JeyJeyGao reviewed Jun 25, 2024
View reviewed changes
notation.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Show resolved Hide resolved
Two-Hearts
Two-Hearts reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, with a few suggestions left.

notation.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Outdated Show resolved Hide resolved
verifier/trustpolicy/blob.go Outdated Show resolved Hide resolved
priteshbandi and others added 4 commits June 26, 2024 22:19
@priteshbandi @Two-Hearts
Update verifier/trustpolicy/blob.go
c797468 
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi @Two-Hearts
Update verifier/trustpolicy/blob.go
123038e 
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi @JeyJeyGao
Update notation.go
ceea1d9 
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@priteshbandi
feedback 5
7653b79 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Two-Hearts
Two-Hearts previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with unit tests fixed.

@priteshbandi
feedback
e201168 
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Two-Hearts
Two-Hearts approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

verifier/trustpolicy/oci.go Show resolved Hide resolved
@priteshbandi priteshbandi merged commit a1825db into notaryproject:main Jun 27, 2024
9 checks passed
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
Closed
6 tasks
@shizhMSFT shizhMSFT mentioned this pull request Aug 14, 2024
Merged
@priteshbandi priteshbandi mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@priteshbandi @codecov-commenter @rgnote @JeyJeyGao @Two-Hearts