Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update README to align with the new brand name #750

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

FeynmanZhou
Copy link
Member

Resolve #715

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou changed the title update README doc: update README to align with the new brand name Jul 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #750 (556b88e) into main (161c972) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files          40       40           
  Lines        2252     2252           
=======================================
  Hits         1441     1441           
  Misses        689      689           
  Partials      122      122           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FeynmanZhou left a few comments

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
yizha1
yizha1 previously approved these changes Jul 31, 2023
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FeynmanZhou LGTM

README.md Outdated Show resolved Hide resolved
Two-Hearts
Two-Hearts previously approved these changes Aug 1, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still comment to resolve, otherwise LGTM.

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou dismissed stale reviews from Two-Hearts and yizha1 via 2e8be90 August 1, 2023 08:39
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


- [Quick start: Sign and validate a container image](https://notaryproject.dev/docs/quickstart/)
- [Try Notation on an online playground](https://killercoda.com/notaryproject/scenario/notation)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Try Notation on an online playground](https://killercoda.com/notaryproject/scenario/notation)
- [Try out Notation in this Killercoda interactive sandbox environment](https://killercoda.com/notaryproject/scenario/notation)

Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added a minor edit.

@shizhMSFT shizhMSFT merged commit 7574cea into notaryproject:main Aug 3, 2023
sajayantony added a commit to sajayantony/notation that referenced this pull request Aug 3, 2023
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
This was referenced Aug 3, 2023
priteshbandi pushed a commit that referenced this pull request Aug 16, 2023
Addresses [the feedback](#750 (comment)) from #750
/cc @gokarnm

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the README for the repository
6 participants