Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: quick fix on notation policy command print out #764

Merged
merged 9 commits into from
Aug 17, 2023
Merged

chore: quick fix on notation policy command print out #764

merged 9 commits into from
Aug 17, 2023

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Aug 15, 2023 •
edited
Loading

No description provided.

@Two-Hearts
fixed notation policy command print outs
f8c3b70 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fixed notation policy command print outs
cb9e06d 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
f5e77c6 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts changed the title fix: fixed notation policy command print outs chore: quick fix on notation policy command print out Aug 15, 2023
@priteshbandi
Copy link
Contributor

Can you please share before and after fix cli output sample ?

@Two-Hearts
Copy link
Contributor Author

Two-Hearts commented Aug 16, 2023 •
edited
Loading

Can you please share before and after fix cli output sample ?

@priteshbandi the change is adding a newline character. For example, if the import trustpolicy is invalid, then the output message is:
Warning: existing trust policy configuration file will be overwrittenError: failed to validate trust policy:...
What we want is:

Warning: existing trust policy configuration file will be overwritten
Error: failed to validate trust policy:...

@Two-Hearts
updated to Fprintln
7cb1789 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #764 (ca62d93) into main (df2aa57) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files          40       40           
  Lines        2252     2252           
=======================================
  Hits         1441     1441           
  Misses        689      689           
  Partials      122      122
Files Changed Coverage Δ
cmd/notation/policy/import.go 77.35% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shizhMSFT
shizhMSFT previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi
Copy link
Contributor

@Two-Hearts looks like 5e1c87ef2829276059e9b131193cd03ff6c70119 commit is not signed

JeyJeyGao
JeyJeyGao previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
Copy link
Contributor Author

Two-Hearts commented Aug 17, 2023 •
edited
Loading

@Two-Hearts looks like 5e1c87ef2829276059e9b131193cd03ff6c70119 commit is not signed

oops, my bad. Signed the commits. @priteshbandi

JeyJeyGao
JeyJeyGao approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 1dc6505 into notaryproject:main Aug 17, 2023
5 checks passed
Two-Hearts added a commit to Two-Hearts/notation that referenced this pull request Aug 18, 2023
@Two-Hearts
chore: quick fix on notation policy command print out (notaryproject#764
7ea606a 
)

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Two-Hearts added a commit to Two-Hearts/notation that referenced this pull request Aug 18, 2023
@Two-Hearts
chore: quick fix on notation policy command print out (notaryproject#764
477f0bb 
)

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts deleted the errMsg branch August 18, 2023 02:58
@shizhMSFT shizhMSFT mentioned this pull request Nov 6, 2023
Merged
6 tasks
@p-linnane p-linnane mentioned this pull request Nov 8, 2023
Merged
@Two-Hearts Two-Hearts mentioned this pull request Jan 25, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Two-Hearts @priteshbandi @codecov-commenter @shizhMSFT @JeyJeyGao