Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links #787

Merged
merged 3 commits into from
Oct 26, 2023
Merged

docs: fix broken links #787

merged 3 commits into from
Oct 26, 2023

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Sep 19, 2023

The link is broken.

https://notaryproject.dev/docs/quickstart/

image

The page that you requested doesn't exist.

Check the URL's spelling.

If you think that the page should exist, create an issue.

So I fixed the link.

https://notaryproject.dev/docs/quickstart-guides/quickstart/

Signed-off-by: Shunsuke Suzuki <suzuki-shunsuke@users.noreply.github.com>
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
@suzuki-shunsuke
Copy link
Contributor Author

I found three broken links.

I confirmed that all broken links are fixed with lychee.

$ git ls-files | grep -E "\.md$" | xargs lychee
⠉ 39/59 ETA 1s █████████████░░░░░░░ ✔ [200] https://docs.microsoft.com/azure/container-registry/container-registry-tutorial-sign-b
⠉ 40/59 ETA 1s █████████████░░░░░░░ ✔ [200] https://github.com/notaryproject/notaryproject/blob/main/specs/trust-store-trust-polic
  59/59 ETA 0s ████████████████████ Finished extracting links                                                                     
🔍 59 Total ✅ 59 OK 🚫 0 Errors

@suzuki-shunsuke suzuki-shunsuke changed the title docs: fix the broken link to Quickstart docs: fix broken links Sep 19, 2023
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #787 (7b5cef3) into main (b7e5a6f) will not change coverage.
Report is 10 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files          40       40           
  Lines        2252     2252           
=======================================
  Hits         1441     1441           
  Misses        689      689           
  Partials      122      122           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 31c9e84 into notaryproject:main Oct 26, 2023
5 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the patch-1 branch October 26, 2023 04:16
Two-Hearts pushed a commit to Two-Hearts/notation that referenced this pull request Nov 3, 2023
The link is broken. https://notaryproject.dev/docs/quickstart/

<img width="638" alt="image"
src="https://github.com/notaryproject/notation/assets/13323303/2ba91685-13ed-4104-befe-ed74fec60ff3">

> The page that you requested doesn't exist.
> 
> Check the URL's spelling.
> 
> If you think that the page should exist, [create an
issue.](https://github.com/notaryproject/notaryproject.dev/issues/new?title=Unexpected%20page-not-found%20error&body=URL%3A%20%0AExpected%20page%3A%20)

So I fixed the link. https://notaryproject.dev/docs/quickstart-guides/quickstart/

---------

Signed-off-by: Shunsuke Suzuki <suzuki-shunsuke@users.noreply.github.com>
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
The link is broken. https://notaryproject.dev/docs/quickstart/

<img width="638" alt="image"
src="https://github.com/notaryproject/notation/assets/13323303/2ba91685-13ed-4104-befe-ed74fec60ff3">

> The page that you requested doesn't exist.
> 
> Check the URL's spelling.
> 
> If you think that the page should exist, [create an
issue.](https://github.com/notaryproject/notaryproject.dev/issues/new?title=Unexpected%20page-not-found%20error&body=URL%3A%20%0AExpected%20page%3A%20)

So I fixed the link. https://notaryproject.dev/docs/quickstart-guides/quickstart/

---------

Signed-off-by: Shunsuke Suzuki <suzuki-shunsuke@users.noreply.github.com>
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
shizhMSFT pushed a commit that referenced this pull request Nov 3, 2023
The link is broken. https://notaryproject.dev/docs/quickstart/

<img width="638" alt="image"
src="https://github.com/notaryproject/notation/assets/13323303/2ba91685-13ed-4104-befe-ed74fec60ff3">

> The page that you requested doesn't exist.
> 
> Check the URL's spelling.
> 
> If you think that the page should exist, [create an
issue.](https://github.com/notaryproject/notaryproject.dev/issues/new?title=Unexpected%20page-not-found%20error&body=URL%3A%20%0AExpected%20page%3A%20)

So I fixed the link. https://notaryproject.dev/docs/quickstart-guides/quickstart/

---------

Signed-off-by: Shunsuke Suzuki <suzuki-shunsuke@users.noreply.github.com>
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
@shizhMSFT shizhMSFT mentioned this pull request Nov 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants