Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

🚿 Remove exec-sync dependency #1

Merged
merged 2 commits into from
May 22, 2018
Merged

🚿 Remove exec-sync dependency #1

merged 2 commits into from
May 22, 2018

Conversation

quilicicf
Copy link

Hi,

I'm creating this PR because the original maintainer never merged this PR.

I saw you forked his project and I thought you're probably my best chance to get rid of my security warning, plus fixing the Windows part is something I tried (and failed) to do.

Thanks for your time

@quilicicf
Copy link
Author

Side note: there's no package-lock.json in the repo.
It might be good to add one.
I didn't do so in my original PR to make it easier to merge but I can add it if it helps.

@notatestuser
Copy link
Owner

Hey, thanks for this, if you could add a package-lock.json I would very much appreciate it. Thank you!

@quilicicf
Copy link
Author

Here you are!

@notatestuser notatestuser merged commit 07cfa1e into notatestuser:master May 22, 2018
@quilicicf quilicicf deleted the master_removeExecSyncWin32 branch May 25, 2018 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants