imp(statemachine)!: increase ICA MaxMemoCharLength (cosmos#5442)

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
notional-labs · Dec 20, 2023 · 335e4ff · 335e4ff
1 parent a89b95a
commit 335e4ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/modules/apps/27-interchain-accounts/types/packet.go b/modules/apps/27-interchain-accounts/types/packet.go
@@ -19,7 +19,7 @@ var (
 )
 
 // MaxMemoCharLength defines the maximum length for the InterchainAccountPacketData memo field
-const MaxMemoCharLength = 256
+const MaxMemoCharLength = 32768
 
 var (
 	// DefaultRelativePacketTimeoutHeight is the default packet timeout height (in blocks) relative

diff --git a/modules/apps/27-interchain-accounts/types/packet_test.go b/modules/apps/27-interchain-accounts/types/packet_test.go
@@ -7,8 +7,6 @@ import (
 	ibctesting "github.com/cosmos/ibc-go/v8/testing"
 )
 
-var largeMemo = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum"
-
 func (suite *TypesTestSuite) TestValidateBasic() {
 	testCases := []struct {
 		name       string
@@ -64,7 +62,7 @@ func (suite *TypesTestSuite) TestValidateBasic() {
 			types.InterchainAccountPacketData{
 				Type: types.EXECUTE_TX,
 				Data: []byte("data"),
-				Memo: largeMemo,
+				Memo: ibctesting.GenerateString(types.MaxMemoCharLength + 1),
 			},
 			false,
 		},