Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic Data field deserialization for 08-wasm structs in CLI #229

Conversation

vmarkushin
Copy link

Particularly, for 10-grandpa client

NOTE: this is not the final design of the feature and, most likely, will be re-implemented on the side of 08-wasm client

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Particularly, for 10-grandpa client

NOTE: this is not the final design of the feature and, most likely, will be re-implemented on the side of 08-wasm client
@vmarkushin vmarkushin requested a review from damiannolan as a code owner July 17, 2023 22:10
@vuong177
Copy link

@vmarkushin @blasrodri I think we also need to decode client state maybeDecodeWasmData in the querier function:

func (q Keeper) ClientState(c context.Context, req *types.QueryClientStateRequest) (*types.QueryClientStateResponse, error) {
and
func (q Keeper) ConsensusState(c context.Context, req *types.QueryConsensusStateRequest) (*types.QueryConsensusStateResponse, error) {

@vmarkushin vmarkushin requested a review from colin-axner as a code owner July 21, 2023 14:50
Copy link

@vuong177 vuong177 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vuong177 vuong177 merged commit 8b6a662 into notional-labs:wasm-client-centauri Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants