-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added capital ligatures #20
Conversation
This MR adds the uppercase ligatures that were missing in the previous implementation. It brings the upper and lower case letters to a baseline. The electronic library of the National Széchenyi Library has ~50 books with single-baseline text. (https://mek.oszk.hu/) Rovas-info is the only publisher that aligns letters to the centerline (~10 books) This MR does not include the accented display, which appears in correspondence of 2-3 people only in the 20th century. The alphabet of the latter uses several incorrect letters ("Y" shaped B, "triangle" shaped O...) |
@simoncozens Plesae merge this MR! |
On branch add_capital_ligatures Changes to be committed: modified: documentation/NotoSansOldHungarian.article.html modified: sources/NotoSansOldHungarian.glyphs
@simoncozens I did not redraw the whole font, my font designer just saved the glyphs file in a different structure. |
@simoncozens The submission 21-115 to Unicode was not accepted building on the following submissions: 22-285 , 23-067 24-003 . |
@simoncozens What does it mean "add more commits"? |
@simoncozens It publicable, I think. |
Strange to change the article just to add ligatures, no? |
The On the main discussion page, which has been frozen, was the need for ligatures in capital letters. There was also a request to align the upper and lower case letters to a baseline. What I added was to optimize the ligatures according to our experience. |
This PR also:
I don't know whether adding all these ligatures is a good idea or not - but I can't accept this PR as it stands because of what it does to the rest of the source file. |
It's my fault.
Sorry, fonforge changed it.
Yes. The Rovas Foundation's request was also on the original discussion paper.
Sorry, I used the FontForge. I am not a perfect developer. I wanted to resolve this quickly.
All right, I'll try to ask someone to prepare it. |
@simoncozens I'll work with it. |
@simoncozens Leave the usability experience to us. We are Hungarians, we can better see what needs to be touched, (in discrete describing) what does not. I close this PR. |
On branch add_capital_ligatures
Changes to be committed:
modified: documentation/NotoSansOldHungarian.article.html
modified: sources/NotoSansOldHungarian.glyphs