Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capital ligatures #20

Closed
wants to merge 1 commit into from
Closed

Added capital ligatures #20

wants to merge 1 commit into from

Conversation

kovacshviktor
Copy link

On branch add_capital_ligatures
Changes to be committed:
modified: documentation/NotoSansOldHungarian.article.html
modified: sources/NotoSansOldHungarian.glyphs

@kovacshviktor
Copy link
Author

This MR adds the uppercase ligatures that were missing in the previous implementation. It brings the upper and lower case letters to a baseline. The electronic library of the National Széchenyi Library has ~50 books with single-baseline text. (https://mek.oszk.hu/) Rovas-info is the only publisher that aligns letters to the centerline (~10 books) This MR does not include the accented display, which appears in correspondence of 2-3 people only in the 20th century. The alphabet of the latter uses several incorrect letters ("Y" shaped B, "triangle" shaped O...)
This MR resolves #15 and #16 issues
Issues #1 and #2 do not belong to this repo.
This MR optimises the use of ligatures in such a way that only consonant + vowel ligatures are included in the discrete ligatures, otherwise the automatism may render the text unreadable. The ligatures "JI", "VV", "KV" and "KSZ" are not included in the discrete ligatures either, because they are reserved for "Y", "W", "Qu" and "X".

@kovacshviktor
Copy link
Author

@simoncozens Plesae merge this MR!

 On branch add_capital_ligatures
 Changes to be committed:
	modified:   documentation/NotoSansOldHungarian.article.html
	modified:   sources/NotoSansOldHungarian.glyphs
@kovacshviktor
Copy link
Author

@simoncozens I did not redraw the whole font, my font designer just saved the glyphs file in a different structure.

@kovacshviktor
Copy link
Author

@simoncozens The submission 21-115 to Unicode was not accepted building on the following submissions: 22-285 , 23-067 24-003 .
The decision-makers are Michael Everson and André Szabolcs Szelp.

@kovacshviktor
Copy link
Author

@simoncozens What does it mean "add more commits"?
I need to add more ligatures?

@kovacshviktor
Copy link
Author

@simoncozens It publicable, I think.

@simoncozens
Copy link
Contributor

Strange to change the article just to add ligatures, no?

@kovacshviktor
Copy link
Author

Strange to change the article just to add ligatures, no?

The On the main discussion page, which has been frozen, was the need for ligatures in capital letters. There was also a request to align the upper and lower case letters to a baseline. What I added was to optimize the ligatures according to our experience.

@simoncozens
Copy link
Contributor

This PR also:

  • Adds a change to the article.
  • Changes the font family name from Noto Sans Old Hungarian to Noto Sans Old Hungarian Regular. "Regular" does not belong in the family name.
  • Changes all the glyph outlines to use quadratic curves. Font sources should use cubic curves.
  • Changed the size of the numerals.
  • The kerning of the new ligatures is written in feature code, rather than in the font's kerning source tables.

I don't know whether adding all these ligatures is a good idea or not - but I can't accept this PR as it stands because of what it does to the rest of the source file.

@kovacshviktor
Copy link
Author

This PR also:

  • Adds a change to the article.
  • Changes the font family name from Noto Sans Old Hungarian to Noto Sans Old Hungarian Regular. "Regular" does not belong in the family name.

It's my fault.

  • Changes all the glyph outlines to use quadratic curves. Font sources should use cubic curves.

Sorry, fonforge changed it.

  • Changed the size of the numerals.

Yes. The Rovas Foundation's request was also on the original discussion paper.

  • The kerning of the new ligatures is written in feature code, rather than in the font's kerning source tables.

Sorry, I used the FontForge. I am not a perfect developer. I wanted to resolve this quickly.

I don't know whether adding all these ligatures is a good idea or not - but I can't accept this PR as it stands because of what it does to the rest of the source file.

All right, I'll try to ask someone to prepare it.

@kovacshviktor
Copy link
Author

@simoncozens I'll work with it.

@kovacshviktor
Copy link
Author

@simoncozens Leave the usability experience to us. We are Hungarians, we can better see what needs to be touched, (in discrete describing) what does not. I close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants