Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks #24

Merged
merged 2 commits into from
Aug 7, 2024
+5 −1
Merged

Minor tweaks #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4439978
* src/basic.c (put_location): Use a descriptive failure message,
notroj Aug 7, 2024
ea12bed
* src/props.c (tests): Run a set/delete/delete sequence, since
notroj Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/basic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ static int put_location(void)
ONNREQ("PUT failed", ne_request_dispatch(req));

ONV(ne_get_status(req)->code != 201,
("PUT to create resource MUST return 201 [RFC9110ẞ9.3.4]"));
("PUT to create '%s' MUST return 201 (got %d) [RFC9110ẞ9.3.4]",
put_uri, ne_get_status(req)->code));

/* PUT to create resource might return Location with 201 [RFC9110ẞ15.3.2] */
s = ne_get_response_header(req, "Location");
Expand All @@ -228,6 +229,7 @@ static int put_location(void)
}

ne_request_destroy(req);
ne_free(put_uri);

return OK;
}
Expand Down
2 changes: 2 additions & 0 deletions src/props.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,8 @@ ne_test tests[] =

T(propmove), T(propget),
T(propdeletes), T(propget),
/* deleting a property twice should succeed. */
T(propset), T(propdeletes), T(propdeletes),
T(propreplace), T(propget),
T(propnullns), T(propget),
T(prophighunicode), T(propget),
Expand Down
Loading