Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.15.11 No SMB connection due to timeout on wrong IP #398

Closed
JJD2K opened this issue Dec 1, 2020 · 145 comments
Closed

v5.15.11 No SMB connection due to timeout on wrong IP #398

JJD2K opened this issue Dec 1, 2020 · 145 comments

Comments

@JJD2K
Copy link

JJD2K commented Dec 1, 2020

v5.15.11 - does not see network with or without smb v2 enabled.

@courville
Copy link
Contributor

courville commented Dec 1, 2020

Can you please provide more details (or remind me) on your network network setup:

  • NAS type and SMB protocol used
  • AndroidTV or phone/tablet interface
  • do you confirm that the issue is that you do not see network being discovered (i.e. no host popping up) in the SMB section?
  • does your former network shortcuts (indexed folders) still work?

Thank you,

@JJD2K
Copy link
Author

JJD2K commented Dec 1, 2020

Hello

  1. It is a Win 7 share - no password. I think I switched something to SMB 1 in win settings for past Android applications to work properly. Note that I am using a no passwords acces EVERYONE account.
  2. Sony TV
  3. Completely missing ANY network. Network is browseable through old ES File explorer instance.
  4. Initially I could see the shows and movies listed - just nothing was playing. Now the entire app after several restarts of the app and tv is empty. Just like clean installation.

@courville
Copy link
Contributor

Thanks for the feedback: I tested a lot of SMB servers including windows ones but not win7.
This is normal that the whole list of video scraped disappears because it is hidden by nova (it is still there): it is simply marked as hidden when detected not available (a bug in your case).
Thus you confirm that no network share is displayed in the smb section under nova.
I can provide a rollback apk to install manually to get you back on track until I figure it out.

@JJD2K
Copy link
Author

JJD2K commented Dec 1, 2020

Hello
That would be very nice thank you!
If you want me to test something let me know before switching back. I have not removed the non-functional version yet.

@courville
Copy link
Contributor

Here it is: https://drive.google.com/file/d/1zyF_AEreUmeuITA3xW_MnZgELJ_UfMA2/view?usp=sharing
I will try to reproduce on my side if I can lay my hands on an antique win7.

@courville
Copy link
Contributor

Before installing new version, if you could just take some adb logs when performing discovery, this could help.
Thx

@JJD2K
Copy link
Author

JJD2K commented Dec 1, 2020

Could you please provide me the command for the log - I forgot it. Maybe add it sticky somewhere.

P.S. Win 7 is much more reliable than newer Win 8 and Win 10. Latest updates to Win 10 always cause incredible problems.

@courville
Copy link
Contributor

The command is adb logcat --pid=$(adb shell pidof -s org.courville.nova) cf. https://github.com/nova-video-player/aos-AVP/wiki/Debugging
Before you need to adb connect to your sony TV.

@JJD2K
Copy link
Author

JJD2K commented Dec 1, 2020

Hello I sent you the log to your email.
Those commands do not work in Windows command line - I think you can not nest the ADB commands like in linux:
the "adb shell pidof -s org.courville.nova" part.

@mschumacher69
Copy link

I have a Windows 7 PC and a Sony TV, let me check if SMB is working on the latest version.

@mschumacher69
Copy link

mschumacher69 commented Dec 1, 2020

Works fine here, using guest share, no password.

@JJD2K
Copy link
Author

JJD2K commented Dec 1, 2020

@courville SMB is working on the version that you sent, but it is a strange version thta has choppy video playback like the one before you fixed the SOUND sync that was causing the stutter issues in the past. Maybe it is version 6 - still no version info in UI - I can not check.

@JJD2K
Copy link
Author

JJD2K commented Dec 1, 2020

My recents list is also lost...maybe I should delete all and go to the previous release?

@courville
Copy link
Contributor

courville commented Dec 2, 2020

@courville SMB is working on the version that you sent, but it is a strange version thta has choppy video playback like the one before you fixed the SOUND sync that was causing the stutter issues in the past. Maybe it is version 6 - still no version info in UI - I can not check.

Just to be clear: I assume we are talking about the version that I sent in the link.
This version is based on the v4.x branch thus without any change with jcifs-ng and movieCollections.

@courville
Copy link
Contributor

Works fine here, using guest share, no password.

On your side you confirm that with a Sony TV and the latest version (v5.x.y) of the app including jcifs-ng and a win7 SMB share without password it works?
/me confused now

@JJD2K
Copy link
Author

JJD2K commented Dec 2, 2020

Hello
I do not understand why you are confused.

  1. LATEST VERSION from google play store does not work - the log that I sent
  2. The version that you sent me works.
  3. Please remove my log - I sent it by email - I do not want my logs published online.

@courville
Copy link
Contributor

Hello
I do not understand why you are confused.

  1. LATEST VERSION from google play store does not work - the log that I sent
  2. The version that you sent me works.
  3. Please remove my log - I sent it by email - I do not want my logs published online.

Logs deleted though it does not help tracking the real issue: github is about code.
To avoid confusion perhaps it would be easier not to use two different users to comment: I thus assume @mschumacher69 = @JJD2K

@courville courville changed the title v5.15.11 No SMB connection v5.15.11 No SMB connection on win7 with unprotected shares SMB1 forced Dec 2, 2020
@courville
Copy link
Contributor

One test that would be nice is to re-enabled SMB2 support on win7 and check if it works any better.

@JJD2K
Copy link
Author

JJD2K commented Dec 2, 2020

Hello
NO I do not know that guy.
@mschumacher69 != @JJD2K
@mschumacher69 <> @JJD2K

@JJD2K
Copy link
Author

JJD2K commented Dec 2, 2020

I tested further the version that you sent, with heavy files that I keep for test and it seems ok. The stutter is only on very heavy scenes so maybe it reaches the maximum of the CPU - 4K scenes with multiple moving particles.
So I confirm again.

  1. The version that I downloaded via the Playstore update - does not see network.
  2. The version that you sent me works.

@mschumacher69
Copy link

@courville we're 2 different users, we're not the same user.

Yes I confirm that on my side, with a Sony TV and the latest version (5.15.11) of the app (not sure about jcifs-ng though, how do I check that?) and a win7 SMB share without password, it works fine.

I also checked in nova's settings and smb v2 is enabled.

@JJD2K
Copy link
Author

JJD2K commented Dec 2, 2020

I now looked at the LOG and it seems WRONG:
The IP of the PC is not: 192.168.25.1
The correct ip is 192.168.1.2

@courville
Copy link
Contributor

Hello
NO I do not know that guy.
@mschumacher69 != @JJD2K
@mschumacher69 <> @JJD2K

OK thus based on this and that I was replying to @mschumacher69 who states that he has smb working with latest nova version using a win7 network shares, I think it warrants some more investigations.

@JJD2K
Copy link
Author

JJD2K commented Dec 2, 2020

Look towards IP - the IP of the computer in the LOG is WRONG.
I do not have a 192.168.25.* subnet at all.

Also it seems both SMB1 and SMB2 are enabled:

PS C:\Program Files\PowerShell\6.0.0-alpha.18> sc.exe qc lanmanworkstation
[SC] QueryServiceConfig SUCCESS

SERVICE_NAME: lanmanworkstation
TYPE : 20 WIN32_SHARE_PROCESS
START_TYPE : 2 AUTO_START
ERROR_CONTROL : 1 NORMAL
BINARY_PATH_NAME : C:\Windows\System32\svchost.exe -k NetworkService
LOAD_ORDER_GROUP : NetworkProvider
TAG : 0
DISPLAY_NAME : Workstation
DEPENDENCIES : Bowser
: MRxSmb10
: MRxSmb20

: NSI
SERVICE_START_NAME : NT AUTHORITY\NetworkService

@dhlavaty
Copy link

dhlavaty commented Dec 2, 2020

Same problem here:
AndroidTV (version 9) on TCL 55C815.
Nova Video Player 5.15.11-20201128.1642
QNAP NAS TS-410 with fw. version 4.2.6

SMB does not work / cannot connect with "Timeout" error message after a long time.

Also tried other Android apps on same TV (VLC, KODI, ...) and they work.

@JJD2K JJD2K changed the title v5.15.11 No SMB connection on win7 with unprotected shares SMB1 forced v5.15.11 No SMB connection on win7 with unprotected shares Dec 2, 2020
@courville
Copy link
Contributor

@dhlavaty could you please try with SMBv2 enabled/disabled in settings?
Do you have SMBv2 enabled on your QNAP?
If you can get some logs too this would help.

@courville
Copy link
Contributor

Look towards IP - the IP of the computer in the LOG is WRONG.
I do not have a 192.168.25.* subnet at all.

@JJD2K good finding, thanks for highlighting this.

@dhlavaty
Copy link

dhlavaty commented Dec 2, 2020

@dhlavaty could you please try with SMBv2 enabled/disabled in settings?

Tried both settings.

Do you have SMBv2 enabled on your QNAP?

There is no such settings on NAS. There is "Allow only NTLMSSP authentication" only. And I've also tried both on and off settings.

If you can get some logs too this would help.

Sorry, I don't have resources to get logs. :-(

@JJD2K
Copy link
Author

JJD2K commented Dec 18, 2020

@courville
G:\ADB>adb pull /sdcard/log.txt logENABLED.txt
adb: error: remote object '/sdcard/log.txt' does not exist

Sorry my mistake you have new locations.

@courville
Copy link
Contributor

@courville
G:\ADB>adb pull /sdcard/log.txt logENABLED.txt
adb: error: remote object '/sdcard/log.txt' does not exist

Sorry: I am messing around with the new logging system.

Here is your rollback version https://drive.google.com/file/d/1fwP6HC7cgTfM5HVA4_XtFfltyCVn19Wf/view?usp=sharing
There should be no logs but we could activate the logs on this version if need be.

@courville
Copy link
Contributor

@JJD2K note that you will need to untick resolver option in your case and force close app and relaunch to have it working.

@JJD2K
Copy link
Author

JJD2K commented Dec 18, 2020

I read that - I amd testing with V2 disabled
Do you want it enabled?

@courville
Copy link
Contributor

Please keep SMBv2 enabled and resolver ticked to get BCAST,DNS that does not work in your case.
It would be good to get a log for the working case too to compare.

@JJD2K
Copy link
Author

JJD2K commented Dec 18, 2020

@courville
V2 enabled does not want to produce log.
G:\ADB>adb pull /sdcard/Download/org.courville.nova/nova-smb.log nova-smb.log
adb: error: remote object '/sdcard/Download/org.courville.nova/nova-smb.log' doe
s not exist
Could this be, because I deleted the file? I will try to reinstall

Works with both resolver orders.

V2 disabled did produce logs amd works only if order is disabled.

@courville
Copy link
Contributor

@courville
V2 enabled does not want to produce log.
G:\ADB>adb pull /sdcard/Download/org.courville.nova/nova-smb.log nova-smb.log
adb: error: remote object '/sdcard/Download/org.courville.nova/nova-smb.log' doe
s not exist
Works with both resolver orders.

V2 disabled did produce logs amd works only if order is disabled.

this is interesting but strange.
Just for me to be sure to get it right:

  • SMBv2 enabled does not produce logs but is working with resolver order option ticked and not ticked (after application force close between each change of settings)
  • SMBv2 disabled produces logs but works only if resolver order option is ticked off

I am interested in getting the logs to check the SMB traces.

Thank you very much for your patience and testing.

@JJD2K
Copy link
Author

JJD2K commented Dec 18, 2020

yes that is what happened ... I will try to reinstall it...maybe because I deleted the file it can not create it.....

@courville
Copy link
Contributor

yes that is what happened ... I will try to reinstall it...maybe because I deleted the file it can not create it.....

it could not recreate it if you do not force close the app (at least this is the only explanation I could come up with).

@JJD2K
Copy link
Author

JJD2K commented Dec 18, 2020

@courville something is messed up with this test. Now v2 does not work with both enabled and disable.
Logs are not recreated if I delete the log file - I have to install the app again for them to be created.

@courville
Copy link
Contributor

courville commented Dec 18, 2020

@courville something is messed up with this test. Now v2 does not work with both enabled and disable.
Logs are not recreated if I delete the log file - I have to install the app again for them to be created.

Just to be sure, when you go in settings and apps and do force stop of the application and relaunch the app it does not recreate the logs right?

You can reinstall the app anyway and do the test one after each other without deleting the logs, I will manage to find the sequence back anyway. What is important is that you force stop the app.

@JJD2K
Copy link
Author

JJD2K commented Dec 18, 2020

@courville
I sent you the logs.
I force stop the app from the HOME button - hold the button and you have the option to kill apps.

I do not know what is wrong but V2 first was running with both orders, then was not working with both orders, then in my test it was working with the disables order and not with the enabled one.....

I had to reinstall the app for the logs to be created.

P.S file names: nova-smb-disabled-V1-working.log
means order - disabled
protocol V1
status working

@courville
Copy link
Contributor

@JJD2K thx for sharing the logs. I will provide the protocol traces to jcifs-ng author. Let's hope that he responds soon (it needs to be in the weekend window: thus just in time).

@spiderdaz
Copy link

spiderdaz commented Dec 19, 2020

@courville im just in the process of getting the latest logs if its not too late.

i have sent logs by 2 seperate emails the smaller set is just from starting the app.
the larger set is the same logs from the same start point but with an attempt to select a share after about 10/15 mins.

@courville
Copy link
Contributor

I am sharing a new apk for testing in the future (no need for now):
With this apk https://drive.google.com/file/d/1BnB7M6LTjGyTawebVO7vYsJWBqAoZVS0/view?usp=sharing you can enable logs via pushing this logback.xml file https://drive.google.com/file/d/1M-wB-bZU4zb-0gcir15qF7AZDaAaP6_6/view?usp=sharing in /sdcard/Download/org.courville.nova/ via:

adb push logback.xml /sdcard/Download/org.courville.nova/logback.xml

After force stop nova and relaunch of nova, it should generates logs and you can pull them via:

adb pull /sdcard/Download/org.courville.nova/nova-smb.log nova-smb.log

and you can remove them via:

adb pull /sdcard/Download/org.courville.nova/nova-smb.log nova-smb.log

To remove log file you can as before do:

adb shell
cd /sdcard/Download/org.courville.nova
rm nova-smb.log
exit

To stop all logs to be generated you can:

adb shell
cd /sdcard/Download/org.courville.nova
rm logback.xml
exit

That way there is no need for a rollback apk.

@courville
Copy link
Contributor

courville commented Dec 20, 2020

@JJD2K, @spiderdaz ok thanks to your testing and logs, we got feedback from jcifs-ng author and I will share shortly a build that should with the same option solve both your problems cf. AgNO3/jcifs-ng#258
I will need however some more testing on your side to share more logs with mbechler.

courville added a commit to nova-video-player/aos-FileCoreLibrary that referenced this issue Dec 20, 2020
@courville
Copy link
Contributor

OK here you go: Video-TEST7.apk that should work with default options (SMBv2 enabled, resolv order BCAST,DNS) https://drive.google.com/file/d/1b3pR1pV2-A-GbZBsKMTGIcNsyOvBkRKl/view?usp=sharing
In oder to collect logs, you need to refer to last procedure (there is no log enabled by default).
What I would need is logs with and without resolv order ticked with between each test a nova force stop).
The idea is for @spiderdaz to understand why the DNS,BCAST order does not work, and for @JJD2K to see if the fix from jcifs-ng author works.
As recommended by jcifs-ng author, one should use DNS,BCAST order.
Thanks you again for your help.

@spiderdaz
Copy link

ok tests with test7.apk
as per instructions.
hopefully got whats needed.
https://drive.google.com/drive/folders/16sCy6IxWYROyYbunSMGUpD72_5SM8SJY?usp=sharing

@spiderdaz
Copy link

Not sure if it has any bearing but I did try to ping the 92.xxxxxxxx address and it just returns a timeout ,so it's definitely not on my network anywhere.

@courville
Copy link
Contributor

@spiderdaz thanks for the logs. I shared them with jcifs-ng author: let's see what comes out of it.
It seems that there is something fishy about your DNS provider/configuration.
Perhaps you can do nslookup 92.xxxxxxxx and provide the result to me.

@courville
Copy link
Contributor

@spiderdaz even better if you could do too nslookup WDMYCLOUD6TB

@spiderdaz
Copy link

ns lookup gave me this
92.242.132.24
Server: cache1.service.virginmedia.net
Address: 194.168.4.100

Name: unallocated.barefruit.co.uk
Address: 92.242.132.24

nslookup wdmy cloud gave me this!!!
nslookup wdmycloud
Server: cache1.service.virginmedia.net
Address: 194.168.4.100

Non-authoritative answer:
Name: wdmycloud
Address: 92.242.132.24

i googled and found this
https://community.virginmedia.com/t5/Networking-and-WiFi/DNS-hijacking-how-to-disable-opt-out/td-p/4145614
i opted out of this piece of crap and now
nslookup mycloud gives me

nslookup wdmycloud
Server: cache1.service.virginmedia.net
Address: 194.168.4.100

*** cache1.service.virginmedia.net can't find wdmycloud: Non-existent domain

im still checking but it seem to have solved the problem.!!
do you want logs??

@spiderdaz
Copy link

spiderdaz commented Dec 20, 2020

Just noticed that mbechler posted the exact same link on the Ng jcifs thread.
My apologies to everyone involved on behalf of virgin media (bastards)

@JJD2K
Copy link
Author

JJD2K commented Dec 21, 2020

@courville Hello I sent you the logs - this version is working with both detection orders on my side - ISSUE solved.
Your logs still don't work though.
After pulling the first log and killing nova.
If I execute the code that you provide:
adb shell cd /sdcard/Download/org.courville.nova rm nova-smb.log exit
in order to clear the old log, the log is no longer generated. Even if I push an empty log file to the TV - still nothing is logged.
I have to reinstall the app with: adb install -r Video-TEST7.apk
for the logs to start working.
Maybe it is a permission issue - I do not know - you have to check your code.

The most important part - issues SOLVED! 👯 🥳 🎈 🕺

@courville
Copy link
Contributor

Just noticed that mbechler posted the exact same link on the Ng jcifs thread.
My apologies to everyone involved on behalf of virgin media (bastards)

I am glad that we we found the root cause. I guess that some other provider will behave the same. I will thus leave the option to switch resolve order. This is important.
Thank you for all the help provided in converging!

@courville
Copy link
Contributor

@spiderdaz, @JJD2K thank you again for your support and all the testing.
I think mbechler fixed the issue. We are good to go for yet another attempt to get SMB2 out at next release for next year.

@mschumacher69
Copy link

Let me get this straight, so the issue was actually with the external DNS server and not with Nova??

@JJD2K
Copy link
Author

JJD2K commented Dec 21, 2020

@mschumacher69 No these are two separate issues. A fix in NOVA is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants