[optional] Use relative path for socket #1087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have #1058 working towards this. Did you look at that? |
|
I did clone yesterday. I got this bug and fixed. Now i see that you have discussion about same problem. I just think to propose you something, it is all. |
|
Let's assume #1058 solves this then and try to get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In out case we run multiple novnc instances and this is looks like:
server/pc1/vnc.htmlserver/pc2/vnc.htmlAnd i had a problem yesterday that socket trying to connect to
server/websockinstead ofserver/pc1/websock, that is correct in my case.I see that you already have issue like this. This code should handle both cases.