In order to reproduce #199, added kotlin-kapt to all kotlin test proj…

…ects.

Added special configuration-only tests that also include kotlin projects even when the tool is Kotlin only.

plugin/src/test/groovy/com/novoda/staticanalysis/internal/checkstyle/CheckstyleConfigurationTest.groovy

@@ -0,0 +1,52 @@
+package com.novoda.staticanalysis.internal.checkstyle
+
+import com.novoda.test.Fixtures
+import com.novoda.test.TestProjectRule
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.junit.runners.Parameterized
+
+@RunWith(Parameterized.class)
+class CheckstyleConfigurationTest {
+
+    @Parameterized.Parameters(name = "{0}")
+    static Iterable<TestProjectRule> rules() {
+        return [
+                TestProjectRule.forJavaProject(),
+                TestProjectRule.forKotlinProject(),
+                TestProjectRule.forAndroidProject(),
+                TestProjectRule.forAndroidKotlinProject(),
+        ]
+    }
+
+    @Rule
+    public final TestProjectRule projectRule
+
+    CheckstyleConfigurationTest(TestProjectRule projectRule) {
+        this.projectRule = projectRule
+    }
+
+    @Test
+    void shouldConfigureSuccessFully() {
+        projectRule.newProject()
+                .withSourceSet('main', Fixtures.Checkstyle.SOURCES_WITH_WARNINGS)
+                .withToolsConfig("checkstyle { }")
+                .build('check', '--dry-run')
+    }
+
+    @Test
+    void shouldNotFailBuildWhenCheckstyleIsConfiguredMultipleTimes() {
+        projectRule.newProject()
+                .withSourceSet('main', Fixtures.Checkstyle.SOURCES_WITH_WARNINGS)
+                .withToolsConfig("""  
+                    checkstyle {
+                        configFile new File('${Fixtures.Checkstyle.MODULES.path}') 
+                    }
+                    checkstyle {
+                        ignoreFailures = false
+                    }  
+                """)
+                .build('check', '--dry-run')
+    }
+}

plugin/src/test/groovy/com/novoda/staticanalysis/internal/checkstyle/CheckstyleIntegrationTest.groovy

@@ -229,22 +229,6 @@ public class CheckstyleIntegrationTest {
                 result.buildFileUrl('reports/checkstyle/main.html'))
     }
 
-    @Test
-    void shouldNotFailBuildWhenCheckstyleIsConfiguredMultipleTimes() {
-        projectRule.newProject()
-                .withSourceSet('main', Fixtures.Checkstyle.SOURCES_WITH_WARNINGS)
-                .withPenalty('none')
-                .withToolsConfig("""  
-                    checkstyle {
-                        configFile new File('${Fixtures.Checkstyle.MODULES.path}') 
-                    }
-                    checkstyle {
-                        ignoreFailures = false
-                    }  
-                """)
-                .build('check', '--dry-run')
-    }
-
     private static String checkstyle(String configFile, String... configs) {
         """checkstyle {
             ${configFile}

plugin/src/test/groovy/com/novoda/staticanalysis/internal/findbugs/FindbugsConfigurationTest.groovy

@@ -0,0 +1,52 @@
+package com.novoda.staticanalysis.internal.findbugs
+
+
+import com.novoda.test.TestProjectRule
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.junit.runners.Parameterized
+
+import static com.novoda.test.Fixtures.Findbugs.SOURCES_WITH_LOW_VIOLATION
+
+@RunWith(Parameterized.class)
+class FindbugsConfigurationTest {
+
+    @Parameterized.Parameters(name = "{0}")
+    static Iterable<TestProjectRule> rules() {
+        return [
+                TestProjectRule.forJavaProject(),
+                TestProjectRule.forKotlinProject(),
+                TestProjectRule.forAndroidProject(),
+                TestProjectRule.forAndroidKotlinProject(),
+        ]
+    }
+
+    @Rule
+    public final TestProjectRule projectRule
+
+    FindbugsConfigurationTest(TestProjectRule projectRule) {
+        this.projectRule = projectRule
+    }
+
+    @Test
+    void shouldConfigureSuccessFully() {
+        projectRule.newProject()
+                .withSourceSet('main', SOURCES_WITH_LOW_VIOLATION)
+                .withToolsConfig("findbugs { }")
+                .build('check', '--dry-run')
+    }
+
+    @Test
+    void shouldNotFailBuildWhenFindbugsIsConfiguredMultipleTimes() {
+        projectRule.newProject()
+                .withSourceSet('main', SOURCES_WITH_LOW_VIOLATION)
+                .withToolsConfig("""
+                    findbugs { }
+                    findbugs {
+                        ignoreFailures = false
+                    }
+                """)
+                .build('check', '--dry-run')
+    }
+}

plugin/src/test/groovy/com/novoda/staticanalysis/internal/findbugs/FindbugsIntegrationTest.groovy

@@ -346,20 +346,6 @@ class FindbugsIntegrationTest {
         Truth.assertThat(result.outcome(':checkFindbugsClasses')).isEqualTo(TaskOutcome.SUCCESS)
     }
 
-    @Test
-    void shouldNotFailBuildWhenFindbugsIsConfiguredMultipleTimes() {
-        projectRule.newProject()
-                .withSourceSet('main', SOURCES_WITH_LOW_VIOLATION)
-                .withPenalty('none')
-                .withToolsConfig("""
-                    findbugs { }
-                    findbugs {
-                        ignoreFailures = false
-                    }
-                """)
-                .build('check')
-    }
-
     @Test
     void shouldBeUpToDateWhenCheckTaskRunsAgain() {
         def project = projectRule.newProject()
@@ -395,7 +381,7 @@ class FindbugsIntegrationTest {
      * The custom task created in the snippet below will check whether {@code Findbugs} tasks with
      * empty {@code source} will have empty {@code classes} too. </p>
      */
-    private String addCheckFindbugsClassesTask() {
+    private static String addCheckFindbugsClassesTask() {
         '''
         project.task('checkFindbugsClasses') {
             dependsOn project.tasks.findByName('evaluateViolations')

plugin/src/test/groovy/com/novoda/staticanalysis/internal/pmd/PmdConfigurationTest.groovy

@@ -0,0 +1,51 @@
+package com.novoda.staticanalysis.internal.pmd
+
+import com.novoda.test.Fixtures
+import com.novoda.test.TestProjectRule
+import org.junit.Rule
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.junit.runners.Parameterized
+
+@RunWith(Parameterized.class)
+class PmdConfigurationTest {
+
+    @Parameterized.Parameters(name = "{0}")
+    static Iterable<TestProjectRule> rules() {
+        return [
+                TestProjectRule.forJavaProject(),
+                TestProjectRule.forKotlinProject(),
+                TestProjectRule.forAndroidProject(),
+                TestProjectRule.forAndroidKotlinProject(),
+        ]
+    }
+
+    @Rule
+    public final TestProjectRule projectRule
+
+    PmdConfigurationTest(TestProjectRule projectRule) {
+        this.projectRule = projectRule
+    }
+
+    @Test
+    void shouldConfigureSuccessFully() {
+        projectRule.newProject()
+                .withSourceSet('main', Fixtures.Pmd.SOURCES_WITH_PRIORITY_1_VIOLATION)
+                .withToolsConfig("pmd { }")
+                .build('check', '--dry-run')
+    }
+
+    @Test
+    void shouldNotFailBuildWhenPmdIsConfiguredMultipleTimes() {
+        projectRule.newProject()
+                .withSourceSet('main', Fixtures.Pmd.SOURCES_WITH_PRIORITY_1_VIOLATION)
+                .withToolsConfig("""  
+                    pmd {
+                    }
+                    pmd {
+                        ignoreFailures = false
+                    }  
+                """)
+                .build('check', '--dry-run')
+    }
+}

plugin/src/test/groovy/com/novoda/staticanalysis/internal/pmd/PmdIntegrationTest.groovy

@@ -213,22 +213,6 @@ public class PmdIntegrationTest {
         assertThat(result.logs).doesNotContainPmdViolations()
     }
 
-    @Test
-    void shouldNotFailBuildWhenPmdIsConfiguredMultipleTimes() {
-        projectRule.newProject()
-                .withSourceSet('main', Fixtures.Pmd.SOURCES_WITH_PRIORITY_1_VIOLATION)
-                .withPenalty('none')
-                .withToolsConfig("""  
-                    pmd {
-                        ruleSetFiles = $DEFAULT_RULES
-                    }
-                    pmd {
-                        ignoreFailures = false
-                    }  
-                """)
-                .build('check')
-    }
-
     private String pmd(String rules, String... configs) {
         """pmd {
             ruleSetFiles = $rules

plugin/src/test/groovy/com/novoda/test/TestAndroidKotlinProject.groovy

@@ -23,6 +23,7 @@ repositories {
 }
 apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
+apply plugin: 'kotlin-kapt' // adding kapt since we face compat issues before
 apply plugin: 'com.novoda.static-analysis'
 
 android {

plugin/src/test/groovy/com/novoda/test/TestKotlinProject.groovy

@@ -19,6 +19,7 @@ plugins {
 }
 
 apply plugin: 'kotlin'
+apply plugin: 'kotlin-kapt' // adding kapt since we face compat issues before
 apply plugin: 'com.novoda.static-analysis'
 
 repositories { 

sample-multi-module/core/build.gradle

@@ -1,12 +1,13 @@
 apply plugin: 'java-library'
 apply plugin: 'kotlin'
+apply plugin: 'kotlin-kapt'
 
 repositories {
     mavenCentral()
 }
 
-dependencies {
-    compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
+dependencies {                
+    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
 }
 
 compileKotlin {

sample/app/build.gradle

@@ -6,6 +6,7 @@ plugins {
 
 apply plugin: 'com.android.application'
 apply plugin: 'kotlin-android'
+apply plugin: 'kotlin-kapt'
 apply plugin: 'kotlin-android-extensions'
 apply plugin: 'com.novoda.static-analysis'