Skip to content

Commit

Permalink
Fix regression in NuGetTargetMoniker for Win8. Fixes #100
Browse files Browse the repository at this point in the history
  • Loading branch information
Oren Novotny committed Jul 29, 2018
1 parent d9b1c74 commit bcc5cee
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Source/MSBuild.Sdk.Extras/Build/Platforms/Windows.targets
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<TargetPlatformVersion>8.0</TargetPlatformVersion>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
<TargetPlatformIdentifier>Windows</TargetPlatformIdentifier>
<NugetTargetMoniker>Windows,Version=v8.0</NugetTargetMoniker>

<!-- Need to override the built-in implicit defines for win8 or it'll be NETCORE4_5 -->
<ImplicitFrameworkDefine Condition="'$(DisableImplicitFrameworkDefines)' != 'true'">WINDOWS8</ImplicitFrameworkDefine>
Expand All @@ -23,6 +24,7 @@
<TargetPlatformVersion>8.1</TargetPlatformVersion>
<TargetFrameworkVersion>v4.5.1</TargetFrameworkVersion>
<TargetPlatformIdentifier>Windows</TargetPlatformIdentifier>
<NugetTargetMoniker>Windows,Version=v8.1</NugetTargetMoniker>

<!-- Need to override the built-in implicit defines for win81 or it'll be NETCORE4_5_1 -->
<ImplicitFrameworkDefine Condition="'$(DisableImplicitFrameworkDefines)' != 'true'">WINDOWS8_1</ImplicitFrameworkDefine>
Expand Down

0 comments on commit bcc5cee

Please sign in to comment.